Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments: Extract comment header cell configuration #17480

Merged
merged 2 commits into from
Nov 17, 2021

Conversation

dvdchr
Copy link
Contributor

@dvdchr dvdchr commented Nov 16, 2021

Refs #17475

This PR introduces a couple of small things:

  • Added a feature flag for the new comment thread.
  • Refactored CommentDetailViewController to move the header cell configuration logic to CommentHeaderTableViewCell, as this header cell will be reused for comment threads later on.
  • Added capability on the header cell to hide the disclosure indicator. Here's how it looks when hidden:
    Screen Shot 2021-11-16 at 18 00 51

To Test

Since this is a minor refactor work, there should be no user-facing changes.

  • Navigate to My Sites > Comments, and select a post comment.
  • 🔍 Verify that the comment header cell is displayed correctly:
    • Top text: Comment on
    • Bottom text: <Title of the post>
    • Disclosure indicator should be displayed.
    • When tapped, leads to the post.
  • Go back to the comments list, and select a reply comment.
  • 🔍 Verify that the comment header cell is displayed correctly:
    • Top text: Reply to <replied author's name>
    • Bottom text: <Snippet of the comment>
    • Disclosure indicator should be displayed.
    • When tapped, leads to the comment thread.

Regression Notes

  1. Potential unintended areas of impact
    Should be none. If any, this should only affect the new comment details in My Sites.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manually tested to ensure there's no impact.

  3. What automated tests I added (or what prevented me from doing so)
    n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Sorry, something went wrong.

@dvdchr dvdchr added this to the 18.8 milestone Nov 16, 2021
@dvdchr dvdchr requested a review from ScoutHarris November 16, 2021 11:05
@dvdchr dvdchr self-assigned this Nov 16, 2021
@peril-wordpress-mobile
Copy link

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

Copy link
Contributor

@ScoutHarris ScoutHarris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 :shipit:

@dvdchr dvdchr merged commit 9516c9b into develop Nov 17, 2021
@dvdchr dvdchr deleted the issue/17475-update-comment-header branch November 17, 2021 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants