Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reader Comments: Track when notification setting is toggled #17369

Merged
merged 2 commits into from
Oct 27, 2021

Conversation

dvdchr
Copy link
Contributor

@dvdchr dvdchr commented Oct 26, 2021

Refs #17363 (comment)
Depends on #17340

This adds a new event, reader_toggle_comment_notifications, which tracks whenever the comments notification setting is toggled. In addition, these properties are added:

  • blog_id: The site ID of the blog that the user enabled the notifications on.
  • notifications_enabled: true if the notifications is enabled, or false otherwise.

To test:

Make sure the "Follow Conversation via Notifications" flag is enabled. You should see 🔵 Tracked: reader_toggle_comment_notifications when:

  • Tapping "Follow" > "Enable" notice action.
  • Tapping the "Undo" notice action.
  • Toggling the switch for the in-app notifications sheet.

Regression Notes

  1. Potential unintended areas of impact
    n/a. Feature is hidden behind a flag.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    n/a. Feature is hidden behind a flag.

  3. What automated tests I added (or what prevented me from doing so)
    n/a. Feature is hidden behind a flag.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Oct 26, 2021

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Oct 26, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

Copy link
Contributor

@ScoutHarris ScoutHarris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion. Otherwise :shipit: !

WordPress/Classes/Services/FollowCommentsService.swift Outdated Show resolved Hide resolved
Base automatically changed from feature/follow-conversation-bottom-sheet to develop October 27, 2021 04:54
@dvdchr dvdchr enabled auto-merge October 27, 2021 05:02
@dvdchr dvdchr merged commit efc422f into develop Oct 27, 2021
@dvdchr dvdchr deleted the feature/follow-conversation-notification-tracks branch October 27, 2021 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants