Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty Stats: Event tracking for Reader discover nudge #17352

Conversation

nikola-milicevic
Copy link
Contributor

Part of #17307

This PR adds tracking events for Reader discover nudge.

Test

  1. Fire the events from the table below
  2. Make sure they fire only once
  3. Validate the events: PCYsg-ktp-p2

Events table

Event Trigger
stats_reader_discover_nudge_shown Fired every time user goes to My Site > Stats screen and Reader discover nudge is shown
stats_reader_discover_nudge_tapped Tap Discover blogs to follow on Reader discover nudge card
stats_reader_discover_nudge_dismissed Tap Dismiss on Reader discover nudge card
stats_reader_discover_nudge_completed Fired when user taps Done on Follow topics screen, while having selected at least one topic to follow

Regression Notes

  1. Potential unintended areas of impact
    n/a

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    n/a

  3. What automated tests I added (or what prevented me from doing so)
    n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Oct 22, 2021

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

Copy link
Contributor

@momo-ozawa momo-ozawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as described! 🎉
I validated the events on Tracks 😄

2021-10-22 11:26:06:637 WordPress[50415:3352932] 🔵 Tracked: stats_reader_discover_nudge_shown <blog_id: 198007634, first_nudge: publicize, site_type: blog>
2021-10-22 11:26:10:945 WordPress[50415:3352932] 🔵 Tracked: stats_reader_discover_nudge_dismissed <blog_id: 198007634, first_nudge: publicize, site_type: blog>
2021-10-22 11:27:38:636 WordPress[50415:3352932] 🔵 Tracked: stats_reader_discover_nudge_tapped <blog_id: 189057154, first_nudge: publicize, site_type: blog>
2021-10-22 11:27:43:393 WordPress[50415:3352932] 🔵 Tracked: stats_reader_discover_nudge_completed <blog_id: 189057154, first_nudge: publicize, site_type: blog>

@nikola-milicevic nikola-milicevic force-pushed the task/empty-stats-event-tracking-for-reader-discover-nudge branch from cad5a09 to 6cb7c86 Compare October 22, 2021 12:29
@nikola-milicevic nikola-milicevic merged commit fc4d97d into task/empty-stats-reader-discover-nudge Oct 22, 2021
@nikola-milicevic nikola-milicevic deleted the task/empty-stats-event-tracking-for-reader-discover-nudge branch October 22, 2021 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants