Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty Stats: Stay on insights tab if Grow Audience card is showing #17332

Merged
merged 2 commits into from
Oct 18, 2021

Conversation

momo-ozawa
Copy link
Contributor

@momo-ozawa momo-ozawa commented Oct 18, 2021

Part of #17122

Ref: pbArwn-2NH-p2#comment-3933

Description

This PR updates the Stats selected period behavior.

  • Grow Audience card showing -> Insights tab will be shown
  • Grow Audience card not showing -> whichever tab the user previously selected will be shown

To test

Site where grow audience card isn't showing

  1. Go to My Site > Stats
  2. Choose a different stats period, and take note of which period you selected
  3. Go back to My Site
  4. Go to Stats
  5. ✅ The selected stats period should be the same one you selected in step 2

Site where grow audience card is showing

  1. Go to My Site > Stats
  2. Choose a different stats period (something other than insights)
  3. Go back to My Site
  4. Go to Stats
  5. ✅ The selected stats period should be insights

Regression Notes

  1. Potential unintended areas of impact
    Stats selected period (aka tabs)

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manually tested both scenarios: showing grow audience card vs not showing grow audience card

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@momo-ozawa
Copy link
Contributor Author

I'm targeting 18.5 because I think this should ship on the first iteration of Empty Stats. Lmk if this is fine -- otherwise, I can change this to target develop.

@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

Copy link
Contributor

@nikola-milicevic nikola-milicevic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Works as described.

@momo-ozawa momo-ozawa merged commit af5fb8d into release/18.5 Oct 18, 2021
@momo-ozawa momo-ozawa deleted the task/empty-stats-saved-tab branch October 18, 2021 12:42
@mokagio
Copy link
Contributor

mokagio commented Oct 19, 2021

@momo-ozawa this has been bundled as part of 18.5 beta 1 (18.5.0.1).

Thanks for your work 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants