Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty Stats: update grow audience ghost cell layout #17205

Merged

Conversation

momo-ozawa
Copy link
Contributor

@momo-ozawa momo-ozawa commented Sep 22, 2021

Description

This PR updates the grow audience ghost cell layout.

Ref: #17142 (comment)

Before After

How to test

  1. Delete app and do a fresh install
  2. Go to My Site > Stats
  3. ✅ Notice that the ghost loading layer matches the new design specs

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Sep 22, 2021

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Sep 22, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@momo-ozawa momo-ozawa force-pushed the task/empty-stats-ghost-layer branch from e11db33 to 0afdbf8 Compare September 22, 2021 13:10
Copy link

@osullivanchris osullivanchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! @leandroalonso does this resolve the concern you had on it?

@leandroalonso
Copy link
Contributor

@osullivanchris yep yep

@momo-ozawa momo-ozawa changed the title Emtpy Stats: update grow audience ghost cell layout Empty Stats: update grow audience ghost cell layout Sep 23, 2021
@momo-ozawa momo-ozawa merged commit b5d0d6b into feature/empty-stats-phase-1 Sep 23, 2021
@momo-ozawa momo-ozawa deleted the task/empty-stats-ghost-layer branch September 23, 2021 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants