Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend App: Enable feature flag to public #17065

Merged
merged 2 commits into from
Aug 23, 2021

Conversation

dvdchr
Copy link
Contributor

@dvdchr dvdchr commented Aug 23, 2021

Refs #16995

Enables the share button feature flag in Me and About screen for general public. Here's a 👀 :

Me screen About screen
me about

⚠️ Please note that this feature is only enabled in WordPress. This feature is disabled for Jetpack. ⚠️

/// Convenience property to determine whether the recomend app section should be displayed or not.
private var isRecommendAppSectionEnabled: Bool {
return FeatureFlag.recommendAppToOthers.enabled && !AppConfiguration.isJetpack
}

/// Convenience property to determine whether the recomend app row should be displayed or not.
private var isRecommendAppRowEnabled: Bool {
FeatureFlag.recommendAppToOthers.enabled && !AppConfiguration.isJetpack
}


To test:

  • Go to Me screen. Verify that the share button is visible, accessible, and works as expected.
  • Go to Me > App Settings > About screen. Verify that the share button is visible, accessible, and works as expected.
  • Repeat the above 👆 with a self-hosted site. Verify that the share button works without a WordPress.com account.

Regression Notes

  1. Potential unintended areas of impact
    Some parts in Me or About screen may not work correctly.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Manually tested that the button is accessible and works as expected.

  3. What automated tests I added (or what prevented me from doing so)
    n/a

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@dvdchr dvdchr added the /Me label Aug 23, 2021
@dvdchr dvdchr added this to the 18.1 ❄️ milestone Aug 23, 2021
@dvdchr dvdchr requested review from aerych and ScoutHarris August 23, 2021 10:32
@dvdchr dvdchr self-assigned this Aug 23, 2021
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Aug 23, 2021

You can test the changes on this Pull Request by downloading it from AppCenter here with build number: 55488. IPA is available here. If you need access to this, you can ask a maintainer to add you.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Aug 23, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Aug 23, 2021

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@dvdchr dvdchr requested a review from mokagio August 23, 2021 10:36
@dvdchr
Copy link
Contributor Author

dvdchr commented Aug 23, 2021

⚠️ I'm enabling auto-merge! ⚠️

@dvdchr dvdchr enabled auto-merge August 23, 2021 10:48
@mokagio
Copy link
Contributor

mokagio commented Aug 23, 2021

cc @startuptester FYI we'll need to ship a new beta to include this feature flag switch. Just in case it helps with your scheduling.

@mokagio
Copy link
Contributor

mokagio commented Aug 24, 2021

@dvdchr this has been bundled as part of 18.1 beta 1 (18.1.0.1).

Thanks for your work 🙌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants