-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recommend App: Enable feature flag to public #17065
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
Generated by 🚫 dangerJS |
|
cc @startuptester FYI we'll need to ship a new beta to include this feature flag switch. Just in case it helps with your scheduling. |
ScoutHarris
approved these changes
Aug 23, 2021
This was referenced Aug 24, 2021
@dvdchr this has been bundled as part of 18.1 beta 1 (18.1.0.1). Thanks for your work 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #16995
Enables the share button feature flag in Me and About screen for general public. Here's a 👀 :
WordPress-iOS/WordPress/Classes/ViewRelated/Me/App Settings/About/AboutViewController.swift
Lines 280 to 283 in a56e6a6
WordPress-iOS/WordPress/Classes/ViewRelated/Me/Me Main/MeViewController.swift
Lines 413 to 416 in a56e6a6
To test:
Regression Notes
Potential unintended areas of impact
Some parts in Me or About screen may not work correctly.
What I did to test those areas of impact (or what existing automated tests I relied on)
Manually tested that the button is accessible and works as expected.
What automated tests I added (or what prevented me from doing so)
n/a
PR submission checklist:
RELEASE-NOTES.txt
if necessary.