Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend App: Add Tracks #17027

Merged
merged 7 commits into from
Aug 19, 2021
Merged

Recommend App: Add Tracks #17027

merged 7 commits into from
Aug 19, 2021

Conversation

dvdchr
Copy link
Contributor

@dvdchr dvdchr commented Aug 13, 2021

Refs #16995, pctCYC-8X-p2#comment-340
Depends on #17020

Summary

This adds tracking events in the ShareAppContentPresenter, with details as described in pctCYC-8X-p2#comment-340. Additionally, I updated TestAnalyticsTracker to store trackString calls (for unit testing purposes).

Note: I'll keep this PR in open until the middle of next week, in case if there are any feedback on the event names, etc.

To Test

There's no visual change, but tests for tracking verification is added. Make sure the tests are ✅ !

Regression Notes

  1. Potential unintended areas of impact
    None.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Added unit tests for the tracking implementation.

  3. What automated tests I added (or what prevented me from doing so)
    Added unit tests for the tracking implementation.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@dvdchr dvdchr added this to the 18.1 milestone Aug 13, 2021
@dvdchr dvdchr self-assigned this Aug 13, 2021
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Aug 13, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Aug 13, 2021

You can trigger an installable build for these changes by visiting CircleCI here.

@dvdchr dvdchr changed the base branch from develop to issue/16996-recommend-app-me-screen August 13, 2021 15:26
@dvdchr dvdchr requested review from ScoutHarris and aerych and removed request for ScoutHarris August 13, 2021 15:27
Copy link
Member

@aerych aerych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Howdy @dvdchr 👋
Tested the events and confirmed they were dispatched as expected. For the failure event I confirmed by disabling wifi. Looks good!
:shipit:

Base automatically changed from issue/16996-recommend-app-me-screen to develop August 19, 2021 15:43
@peril-wordpress-mobile
Copy link

Warnings
⚠️ This PR is assigned to a milestone which is closing in less than 4 days Please, make sure to get it merged by then or assign it to a later expiring milestone

Generated by 🚫 dangerJS

@dvdchr
Copy link
Contributor Author

dvdchr commented Aug 19, 2021

Thank you!

@dvdchr dvdchr merged commit db0c446 into develop Aug 19, 2021
@dvdchr dvdchr deleted the feature/recommend-app-tracks branch August 19, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants