Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gutenberg] Global Style Settings Analytics #16846

Merged
merged 6 commits into from
Jul 14, 2021
Merged

Conversation

chipsnyder
Copy link
Contributor

@chipsnyder chipsnyder commented Jul 12, 2021

Description

This is built off of #16823 and should be merged afterwards.

These events are being registered in: https://github.com/Automattic/tracks-events-registration/pull/517

To test:

FSE Theme with /wp-block-editor/v1/settings

  1. Set up a site that uses a FSE theme, and enable the GSS Settings via the debug options
  2. Navigate to the editor
  3. Expect to see the event wpios_editor_settings_fetched <endpoint: wp-block-editor, full_site_editing: true>

Traditional Theme with /wp-block-editor/v1/settings

  1. Set up a site that is using a non-FSE theme, and enable the GSS Settings via the debug options
  2. Navigate to the editor
  3. Expect to see the event wpios_editor_settings_fetched <endpoint: wp-block-editor, full_site_editing: false>

Traditional Theme with /wp/v2/themes

  1. Set up a site that is using a non-FSE theme, and diable the GSS Settings or select a self-hosted site with the base WP install
  2. Navigate to the editor
  3. Expect to see the event wpios_editor_settings_fetched <endpoint: theme_supports, full_site_editing: false>

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    This is just an analytics event change

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jul 12, 2021

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jul 12, 2021

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@chipsnyder chipsnyder changed the base branch from develop to gutenberg/gss/endpoint_update July 12, 2021 19:24
@chipsnyder chipsnyder marked this pull request as ready for review July 12, 2021 19:24
Copy link

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code changes look good and the app works as expected 🎉
Great work Chip 👍

Base automatically changed from gutenberg/gss/endpoint_update to develop July 14, 2021 21:22
@chipsnyder chipsnyder added this to the 17.9 milestone Jul 14, 2021
@chipsnyder chipsnyder merged commit a704876 into develop Jul 14, 2021
@chipsnyder chipsnyder deleted the gutenberg/gss/analytics branch July 14, 2021 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants