Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass the Gallery v2 Flag over from the editor #16832

Merged
merged 14 commits into from
Sep 2, 2021
Merged

Pass the Gallery v2 Flag over from the editor #16832

merged 14 commits into from
Sep 2, 2021

Conversation

chipsnyder
Copy link
Contributor

@chipsnyder chipsnyder commented Jul 8, 2021 •
edited
Loading

Related PRs
gutenberg: WordPress/gutenberg#33314
gutenberg-mobile: wordpress-mobile/gutenberg-mobile#3713
WordPressKit-iOS: wordpress-mobile/WordPressKit-iOS#417

Description:

This PR is built off of #16823 That PR should be reviewed and merged before this one.

To test:

This can be tested with the instructions contained here: WordPress/gutenberg#33314

Regression Notes

  1. Potential unintended areas of impact
    This could also affect the changes for Global Style Settings

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    They can be retested with:

  • Offline Support - steps
  • FSE Colors and Gradients - steps
  • FSE Offline Support - steps
  1. What automated tests I added (or what prevented me from doing so)
    These changes are covered by the existing Unit Tests

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jul 8, 2021 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jul 8, 2021 •
edited
Loading

You can trigger an installable build for these changes by visiting CircleCI here.

@chipsnyder chipsnyder mentioned this pull request Jul 8, 2021
Merged
7 tasks
@chipsnyder chipsnyder mentioned this pull request Jul 9, 2021
Merged
2 tasks
@chipsnyder chipsnyder requested a review from antonis July 9, 2021 21:03
@chipsnyder chipsnyder added Gutenberg Editing and display of Gutenberg blocks. [Type] Enhancement labels Jul 9, 2021
@chipsnyder chipsnyder mentioned this pull request Jul 9, 2021
Merged
1 task
@chipsnyder chipsnyder marked this pull request as ready for review July 9, 2021 21:06
@chipsnyder chipsnyder force-pushed the rnmobile/refactor/gallery-as-nested-image-blocks-editor-settings_v2 branch from 5a8f8ce to df7f892 Compare July 12, 2021 16:47
chipsnyder
chipsnyder commented Jul 12, 2021
View reviewed changes
WordPress/Classes/Models/BlockEditorSettings+GutenbergEditorSettings.swift
@@ -60,6 +73,16 @@ extension BlockEditorSettings {
parsedElements.insert(BlockEditorSettingElement(fromRawRepresentation: gradient, type: .gradient, order: index, context: context))
})

// Experimental Features
let galleryKey = BlockEditorExperimentalFeatureKeys.galleryRefactor.rawValue
let galleryRefactor = BlockEditorSettingElement(name: galleryKey,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this flag is expected to be temporary I'm storing it in the BlockEditorSettingElement as a new type experimentalFeatures

@chipsnyder chipsnyder changed the base branch from develop to gutenberg/gss/endpoint_update July 12, 2021 19:23
@chipsnyder chipsnyder mentioned this pull request Jul 12, 2021
Merged
4 tasks
Base automatically changed from gutenberg/gss/endpoint_update to develop July 14, 2021 21:22
@antonis
Copy link

antonis commented Jul 15, 2021 •
edited
Loading

Hey @chipsnyder 👋
I had a look at the Gallery flag PRs and everything LGTM 👍
If you agree, I will postpone the full review/testing a bit since there are some ongoing discussions on the web pr (e.g. around the naming of the parameter) that may affect this work.

@chipsnyder
Copy link
Contributor Author

If you agree, I will postpone the full review/testing a bit since there are some ongoing discussions on the web pr (e.g. around the naming of the parameter) that may affect this work.

That sounds like a good plan to me 👍 Thank you for keeping an eye on that parent issue

@antonis
Copy link

antonis commented Jul 19, 2021 •
edited
Loading

there are some ongoing discussions on the web pr (e.g. around the naming of the parameter) that may affect this work.

@chipsnyder Indeed this parameter was renamed from __experimentalGalleryRefactor to __unstableGalleryWithInnerBlocks (or GalleryWithImageBlocks). I will proceed with the changes on the Android side once this settles.

antonis
antonis approved these changes Aug 3, 2021
View reviewed changes
Copy link

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @chipsnyder 👍
This LGTM 🎉

Chip and others added 2 commits August 4, 2021 11:29
[Gallery Refactor] Analytics (#16848)
c5cfebd 
* Add Gallery flag to editor session start

* Update analytic key names for gallery refactor
Merge branch 'develop' into rnmobile/refactor/gallery-as-nested-image…
6269551 
…-blocks-editor-settings_v2

# Conflicts:
#	Podfile
#	Podfile.lock
@antonis antonis requested a review from mkevins September 1, 2021 08:49
mkevins
mkevins approved these changes Sep 2, 2021
View reviewed changes
Copy link
Contributor

@mkevins mkevins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested these changes and everything is working as expected. Thanks for adding this!

Just needs conflicts to be resolved before merging. 👍

Antonis Lilis added 2 commits September 2, 2021 13:33
Merge branch 'develop' into rnmobile/refactor/gallery-as-nested-image…
f7804be 
…-blocks-editor-settings_v2

# Conflicts:
#	Podfile
#	Podfile.lock
Reverse config change
35156a3
@antonis antonis added this to the 18.2 milestone Sep 2, 2021
@antonis antonis merged commit ea2cfdf into develop Sep 2, 2021
@antonis antonis deleted the rnmobile/refactor/gallery-as-nested-image-blocks-editor-settings_v2 branch September 2, 2021 11:29
@dcalhoun dcalhoun mentioned this pull request Sep 7, 2021
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkevins mkevins mkevins approved these changes

@antonis antonis antonis approved these changes

Assignees
No one assigned
Labels
Gutenberg Editing and display of Gutenberg blocks. [Type] Enhancement
Projects
None yet
Milestone
18.2
Development

Successfully merging this pull request may close these issues.
3 participants
@chipsnyder @antonis @mkevins