Fixes color picker segmented control rendering and scrolling issues #16366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can trigger an installable build for these changes by visiting CircleCI here. |
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
This was referenced Apr 23, 2021
antonis
force-pushed
the
gutenberg/issue/30878-colorpicker
branch
3 times, most recently
from
30d710d to
31055ff
Compare
|
Build 47260 is available on AppCenter |
antonis
force-pushed
the
gutenberg/issue/30878-colorpicker
branch
from
31055ff to
8f64b90
Compare
dcalhoun
approved these changes
May 6, 2021
|
Closing this since it was meant for testing WordPress/gutenberg#30994 |
Generated by 🚫 dangerJS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes wordpress-mobile/gutenberg-mobile#3104
gutenberg: WordPress/gutenberg#30994gutenberg-mobile: wordpress-mobile/gutenberg-mobile#3394WordPress-Android: wordpress-mobile/WordPress-Android#14492To test:
Follow the steps on the
gutenbergprRegression Notes
Potential unintended areas of impact
None identified
What I did to test those areas of impact (or what existing automated tests I relied on)
Followed testing steps on the
gutenbergprWhat automated tests I added (or what prevented me from doing so)
This PR only updates the
gutenberg-mobileversion and does not introduce iOS native code.PR submission checklist:
RELEASE-NOTES.txtif necessary.