Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds some missing translations for the iOS 14 All Time widget #16135

Merged
merged 2 commits into from
Mar 19, 2021

Conversation

Gio2018
Copy link
Contributor

@Gio2018 Gio2018 commented Mar 19, 2021

Fixes #NA

This PR adds translations for "Best views ever" and "Posts" in the medium size All Time widget.

To test:

  • build, run and install a medium size All Time widget
  • set any language on your device and make sure that the translations of "Best views ever" and "Posts" look correct. They can me matched against the Localizable.strings files that can be found in the WordPress target.

Notes:

  • some languages did not have translations for one or both the two strings, in this case it will default to English
  • the Italian translation of "Best views ever" in the widget will be different than the one in the main app (only exception): the translation was replaced with a shorter one with the same meaning.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

cc @jkmassel , this targets release 16.9.

@Gio2018 Gio2018 added this to the 16.9 ❄️ milestone Mar 19, 2021
@Gio2018 Gio2018 requested a review from mindgraffiti March 19, 2021 20:07
@Gio2018 Gio2018 self-assigned this Mar 19, 2021
@peril-wordpress-mobile
Copy link

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

Copy link
Contributor

@mindgraffiti mindgraffiti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @Gio2018!

:shipit:

@Gio2018
Copy link
Contributor Author

Gio2018 commented Mar 19, 2021

Thank you for reviewing @mindgraffiti !!

@Gio2018 Gio2018 merged commit c944068 into release/16.9 Mar 19, 2021
@Gio2018 Gio2018 deleted the fix/widgets-translations branch March 19, 2021 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants