Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes magic links. #15557

Merged
merged 9 commits into from
Jan 8, 2021
Merged

Conversation

diegoreymendez
Copy link
Contributor

@diegoreymendez diegoreymendez commented Dec 23, 2020

WPAuth PR: wordpress-mobile/WordPressAuthenticator-iOS#553
WPKit PR: wordpress-mobile/WordPressKit-iOS#322

Fixes a bug that was causing magic links to sometimes not execute the right tracking calls.

Testing:

Please breakpoints here:

Test 1: Login -> Signup -> Login

  1. Be logged out
  2. Request a magic link to login to an existing account of yours. Don’t tap on the link.
  3. Go back and request another magic link to a new account. (Hint: If you’re using google you can use the + trick and use [email protected])
  4. Now using your device, tap on the link from the first email (the login email from step 2)
  5. Make sure both breakpoints take you through the login flow.
  6. Make sure the epilogue shown is the login epilogue.

Test 2: Signup -> Login -> Signup

  1. Be logged out
  2. Request a magic link to sign up with a new account. Don’t tap on the link.
  3. Go back and request another magic link to an existing account.
  4. Now using your device, tap on the link from the first email (the signup email from step 2)
  5. Make sure both breakpoints take you through the signup flow.
  6. Make sure the epilogue shown is the signup epilogue.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Dec 23, 2020

You can trigger an installable build for these changes by visiting CircleCI here.

@diegoreymendez diegoreymendez changed the title Updates WPAuth, WPKit. Fixes magic links. Dec 23, 2020
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Dec 23, 2020

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

Copy link
Contributor

@Gio2018 Gio2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested both scenarios and the breakpoints were hit as described, and the right epilogues were presented. LGTM!

@diegoreymendez
Copy link
Contributor Author

Thanks @Gio2018 ! Starting the merge process.

@diegoreymendez diegoreymendez merged commit 9ca7a00 into develop Jan 8, 2021
@diegoreymendez diegoreymendez deleted the try/fix-magic-link-login-and-signup branch January 8, 2021 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants