-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes magic links. #15557
Fixes magic links. #15557
Conversation
You can trigger an installable build for these changes by visiting CircleCI here. |
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested both scenarios and the breakpoints were hit as described, and the right epilogues were presented. LGTM!
Thanks @Gio2018 ! Starting the merge process. |
WPAuth PR: wordpress-mobile/WordPressAuthenticator-iOS#553
WPKit PR: wordpress-mobile/WordPressKit-iOS#322
Fixes a bug that was causing magic links to sometimes not execute the right tracking calls.
Testing:
Please breakpoints here:
Test 1: Login -> Signup -> Login
Test 2: Signup -> Login -> Signup
PR submission checklist:
RELEASE-NOTES.txt
if necessary.