Gutenberg - Fix Gallery block uploads when the editor is closed #15457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![test-case-reminder[bot]](https://avatars.githubusercontent.com/u/1306301?s=60&v=4){kind=small}
There was a problem hiding this comment.
Here are some suggested test cases for this PR.
If you think that suggestions should be improved please edit the configuration file here. You can also modify/add test-suites to be used in the configuration.
If you are a beginner in mobile platforms follow build instructions.
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
3 tasks
|
I added an issue WordPress/gutenberg#27618 for this PR to fix and update the PR description to reflect this. |
chipsnyder
approved these changes
Dec 9, 2020
There was a problem hiding this comment.
Ran the sanity tests on this branch with the Gutenberg release and everything worked great. Thanks for taking care of this @geriux 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue found while sanity testing the
1.43.0Gutenberg mobile release.Fixes WordPress/gutenberg#27618
Due to this Gutenberg change that updated the values for the
linkToattribute, the Gallery processor stopped working correctly. This PR updates the values to the new ones:media→fileattachment→postIt also takes into account the default value
noneto process the images without links.To test:
Test the different Gallery link to options:
None,Media File, andAttachment PagePR submission checklist:
RELEASE-NOTES.txtif necessary.