[Home Page Picker] Add Template to Preview analytics

[chipsnyder]

Fixes wordpress-mobile/gutenberg-mobile#2720
📓 This helps align the approach taken on iOS and Android to include the template property in the loading preview analytics

📓 This does not include any of the changes in #15360

To test:

📓 This was branched off of the enable PR so no need to enable HPP unless you have it overridden

To disable or enable the development version of Home Page Picker

• Open the app from the build that allows FeatureFlags such as a PR build or a local development build
  • By default, the modal layout picker will be disabled.
  • From the site page:
    • Click on your Gravatar.
    • Click on App Settings.
    • Click on Debug.
    • Toggle "Site Creation: Home Page Picker" to enable or disable the picker
    • 

📓 To help with testing these you can filter the console logs on Tracked:

1. Navigate to the Create WordPress.com site
   • My Sites > ➕ > Create WordPress.com site
2. Select a site design
3. Select Preview
   • Expect to see the event enhanced_site_creation_site_design_preview_viewed fire with the parameter template populated with the selected design's slug
4. When the URL starts loading
   • Expect to see the event enhanced_site_creation_site_design_preview_loading fire with the parameter template
5. When the URL successfully loads
   • Expect to see the event enhanced_site_creation_site_design_preview_loaded fire with the parameter template
6. Select Choose
   • Expect to see the event enhanced_site_creation_site_design_selected fire with the parameter template

Additional Context:

This is a continuation of the work done in the Home Page Picker Project and is part of the Round 2 requirements.

PR submission checklist:

• I have considered adding unit tests where possible.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

[peril-wordpress-mobile]

You can test the changes on this Pull Request by downloading it from AppCenter here with build number: 38237. IPA is available here. If you need access to this, you can ask a maintainer to add you.

[chipsnyder]

@antonis I didn't include the template in the case of if a preview fails to load. Did you include the template in that scenario?

[antonis]

@antonis I didn't include the template in the case of if a preview fails to load. Did you include the template in that scenario?

I didn't think to include this either. It is easy to add it in the error message text though.

There are two cases I report this:

• When the connection is down
• When an error loading the preview comes up

I guess if we add this information it would be useful only in the second case. Wdyt?

[peril-wordpress-mobile]

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

[chipsnyder]

I guess if we add this information it would be useful only in the second case. Wdyt?

Yeah, I don't we really need it for this flow. We would be able to set up filters to see how much each is erroring without it anyway. So I think we can leave it off

[antonis]

The changes LGTM 🎉
Nice work @chipsnyder 👍

[mkevins]

Thanks for adding this!

We would be able to set up filters to see how much each is erroring without it anyway. So I think we can leave it off

My thoughts exactly.. once we have the preview_{viewed,loading,loaded} events, we'll see if there is a problem with a particular template preview loading from that.