Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page Settings: set display titles to "Page Settings" if a page is being editing. #15207

Merged
merged 1 commit into from
Nov 3, 2020

Conversation

ScoutHarris
Copy link
Contributor

Fixes #12374

When editing a page, change settings titles to Page Settings instead of Post Settings.

To test:

  • Edit a Page.
    • Select ... on the nav bar.
    • Verify the settings option is Page Settings.
  • Switch to classic editor.
    • Select ... on the nav bar.
    • Verify the settings option is Page Settings.
  • Select Page Settings.
    • Verify the view title is Page Settings.
Gutenberg menu Classic menu Settings view
gutenberg_menu aztec_menu settings_title

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@peril-wordpress-mobile
Copy link

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

Copy link
Contributor

@mindgraffiti mindgraffiti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ScoutHarris
Copy link
Contributor Author

Thanks @mindgraffiti !

@ScoutHarris ScoutHarris merged commit 28aeee2 into develop Nov 3, 2020
@ScoutHarris ScoutHarris deleted the fix/12374-page_settings_titles branch November 3, 2020 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Page Settings Option Labeled as Post Setting
2 participants