Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate Aztect-iOS 1.19.3 #14444

Merged
merged 6 commits into from
Jul 15, 2020
Merged

Integrate Aztect-iOS 1.19.3 #14444

merged 6 commits into from
Jul 15, 2020

Conversation

chipsnyder
Copy link
Contributor

@chipsnyder chipsnyder commented Jul 8, 2020 •
edited
Loading

To test:

  • Make sure CI builds ok
  • Make sure Gutenberg and Classic editor open fine

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@chipsnyder chipsnyder requested a review from SergioEstevao July 8, 2020 22:23
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jul 8, 2020 •
edited
Loading

You can trigger an installable build for these changes by visiting CircleCI here.

@chipsnyder chipsnyder modified the milestones: Someday, 15.3 Jul 8, 2020
@chipsnyder
Copy link
Contributor Author

Marked this as 15.3 but this isn't required until Gutenberg Mobile 1.33 so I'm fine letting it sit till then.

@chipsnyder chipsnyder mentioned this pull request Jul 8, 2020
Closed
2 tasks
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jul 8, 2020 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@chipsnyder chipsnyder modified the milestones: 15.3, 15.4 Jul 9, 2020
@chipsnyder
Copy link
Contributor Author

Changing this to 15.4 just to keep everything between WPiOS and Gutenberg-Mobile in sync

@chipsnyder chipsnyder mentioned this pull request Jul 9, 2020
Merged
2 tasks
SergioEstevao
SergioEstevao approved these changes Jul 15, 2020
View reviewed changes
Copy link
Contributor

@SergioEstevao SergioEstevao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@SergioEstevao
Copy link
Contributor

Make sure to merge the GB-mobile PR first.

@chipsnyder chipsnyder merged commit 8799872 into develop Jul 15, 2020
@chipsnyder chipsnyder deleted the integrate/Aztec-1.19.3 branch July 15, 2020 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SergioEstevao SergioEstevao SergioEstevao approved these changes

Assignees
No one assigned
Labels
Aztec
Projects
None yet
Milestone
15.4
Development

Successfully merging this pull request may close these issues.
2 participants
@chipsnyder @SergioEstevao