Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UL&S: Add TextLinkTableViewCell to SiteAddressViewController #14372

Merged
merged 13 commits into from
Jun 25, 2020
Merged

UL&S: Add TextLinkTableViewCell to SiteAddressViewController #14372

merged 13 commits into from
Jun 25, 2020

Conversation

mindgraffiti
Copy link
Contributor

@mindgraffiti mindgraffiti commented Jun 23, 2020 •
edited
Loading

Ref. #14009
Ref. PR: wordpress-mobile/WordPressAuthenticator-iOS#308

This PR adds more base UI to the unified login & signup project. The TextLinkTableViewCell is used any time there is a hint button styled like a text link, such as "Reset your password" or "Find your site address".

To test:

  1. rake dependencies
  2. build and run
  3. Log In > Or log in by entering your site address.
  4. Observe the keyboard behavior: the site url textfield becomes first responder and the Continue button slides up.
  5. Tap the "Find site address" text link button
  6. Expected: the fancy alert message is presented.

Screenshots

Do not merge until:

  1. Feature flag is disabled for .unifiedSiteAddress
  2. The Authenticator PR has been merged: UL&S: Add TextLinkTableViewCell to SiteAddressViewController WordPressAuthenticator-iOS#308
  3. A new Authenticator release has been created
  4. The release is published on Cocoapods trunk
  5. This PR points to the new release

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@mindgraffiti mindgraffiti self-assigned this Jun 23, 2020
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 23, 2020 •
edited
Loading

You can trigger an installable build for these changes by visiting CircleCI here.

@mindgraffiti mindgraffiti changed the title Feature/14009 unify site address vi UL&S: Add TextLinkTableViewCell to SiteAddressViewController Jun 23, 2020
@github-actions
Copy link

github-actions bot commented Jun 23, 2020 •
edited
Loading

Fails
🚫 Podfile: reference to a commit hash

Generated by 🚫 dangerJS against ab6a5fd

@mindgraffiti mindgraffiti mentioned this pull request Jun 23, 2020
Merged
@mindgraffiti mindgraffiti added this to the 15.2 milestone Jun 23, 2020
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 23, 2020 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

Gio2018
Gio2018 approved these changes Jun 23, 2020
View reviewed changes
Copy link
Contributor

@Gio2018 Gio2018 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked as expected
:shipit: !

ScoutHarris
ScoutHarris reviewed Jun 24, 2020
View reviewed changes
WordPress/Classes/ViewRelated/NUX/WordPressAuthenticationManager.swift Outdated
@@ -39,6 +39,7 @@ class WordPressAuthenticationManager: NSObject {
enableSignInWithApple: enableSignInWithApple,
enableSignupWithGoogle: true,
enableUnifiedAuth: FeatureFlag.unifiedAuth.enabled,
displayHintButtons: true,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since displayHintButtons defaults to true, this isn't necessary.

@mindgraffiti mindgraffiti requested a review from ScoutHarris June 25, 2020 13:19
@mindgraffiti
Copy link
Contributor Author

thank you for the reviews @ScoutHarris and @Gio2018!

@mindgraffiti mindgraffiti merged commit c489b3f into develop Jun 25, 2020
@mindgraffiti mindgraffiti deleted the feature/14009-unify-site-address-vi branch June 25, 2020 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gio2018 Gio2018 Gio2018 approved these changes

@ScoutHarris ScoutHarris ScoutHarris approved these changes

Assignees

@mindgraffiti mindgraffiti

Labels
Login [Type] Enhancement
Projects
None yet
Milestone
15.2
Development

Successfully merging this pull request may close these issues.
3 participants
@mindgraffiti @ScoutHarris @Gio2018