Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove formatterkit #14321

Merged
merged 2 commits into from
Jun 16, 2020
Merged

Remove formatterkit #14321

merged 2 commits into from
Jun 16, 2020

Conversation

jkmassel
Copy link
Contributor

@jkmassel jkmassel commented Jun 15, 2020 •
edited
Loading

Running bundle exec pod outdated tells us that the FormatterKit pod is unused in the project.

Deleting it compiles and passes all tests, so I'd imagine it's safe to remove.

#14320 must be merged before opening this for review.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@jkmassel jkmassel added this to the 15.2 milestone Jun 15, 2020
@jkmassel jkmassel self-assigned this Jun 15, 2020
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 15, 2020 •
edited
Loading

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Jun 15, 2020 •
edited
Loading

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@jkmassel jkmassel force-pushed the try/removing-formatterkit branch from 9b366eb to 1682d2d Compare June 15, 2020 21:16
@jkmassel jkmassel requested a review from oguzkocer June 15, 2020 22:30
@jkmassel jkmassel marked this pull request as ready for review June 15, 2020 22:31
@oguzkocer oguzkocer merged commit c43ba2d into develop Jun 16, 2020
@oguzkocer oguzkocer deleted the try/removing-formatterkit branch June 16, 2020 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oguzkocer oguzkocer oguzkocer approved these changes

Assignees

@jkmassel jkmassel

Labels
[Type] Tech Debt
Projects
None yet
Milestone
15.2
Development

Successfully merging this pull request may close these issues.
2 participants
@jkmassel @oguzkocer