[Gutenberg] Enable build from monorepo #14188

ceyhun · 2020-05-26T12:55:48Z

Description

This PR adds the necessary changes for building WordPress-iOS using the new Gutenberg/Gutenberg-Mobile Monorepo setup.

Related PR's:

Gutenberg Monorepo PR's for fixing WPiOS build

GB-Mobile: Target gutenberg monorepo branch gutenberg-mobile#2172
Gutenberg: [RNMobile][Monorepo] Make the native app customizable by a parent app WordPress/gutenberg#21332

To test:

PR submission checklist:

I have considered adding unit tests where possible.
I have considered adding accessibility improvements for my changes.
I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

peril-wordpress-mobile · 2020-05-26T12:55:53Z

You can trigger an installable build for these changes by visiting CircleCI here.

peril-wordpress-mobile · 2020-05-26T13:25:52Z

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

peril-wordpress-mobile · 2020-05-29T07:18:54Z

	Warnings
⚠️	This PR is tagged with 'DO NOT MERGE'.

Generated by 🚫 dangerJS

chipsnyder · 2020-06-15T17:58:05Z

Regression Testing progress:

DarkMode-1

Gallery block - Dark mode - steps
Shortcode block - Dark mode - steps
Media Text block - Dark mode - steps

DarkMode-2

Spacer block - Dark mode - steps
Buttons block - Dark mode - steps
Group - Dark mode - steps
Columns - Dark mode - steps

Group-1

Group - AppenderButton is rendered - steps
❌ Group - Deep nesting is possible (iOS only) - steps
- [Gutenberg] Enable build from monorepo #14188 (comment)
Group - Check if Group placeholder is visible for the unselected state - steps
Group - Check if Group placeholder is render in nested structure - steps
Group - Nested block have proper border styling - steps
Group - Nested block have proper margins values - steps
Group - Breadcrumbs on FloatingToolbar is properly displayed - steps

Group-2

Group - Navigation up button works as expected - steps
Group - Navigation down works according to parent-first approach - steps
❓ Group - Cross navigation between blocks works as expected - steps
- Didn't test yet do to [Gutenberg] Enable build from monorepo #14188 (comment)
Group - Ungroup button works as expected - steps
Group - Check if in DarkMode all components gets proper colors - steps
Group - Check if nested Placeholder block can be replaced - steps

Spacer-1

Spacer block - Spacer is rendered without crash - steps
Spacer block - Settings: Control spacer height using the slider - steps
Spacer block - Settings: Control spacer height using the text input - steps

Spacer-2

Spacer block - Settings: Available height range is correct - steps
Spacer block - Settings: Height range extends if Spacer comes from the web is higher than 500px - steps
Spacer block - Spacer in horizontal layout works as expected - steps

Buttons-1

Buttons block - Buttons block is added with focused Button with gray background color and white text color - steps
Buttons block - Buttons inline appender - steps
Buttons block - Add another Button inside Buttons using inserter - steps

Buttons-2

Buttons block - Removing Button along with Buttons block - steps
Buttons block - Removing exactly one Button (when Buttons contain more of them) - steps

Buttons-3

Buttons block - Wrapping Buttons - steps
Buttons block - Buttons alignment options - steps

Buttons-4

Buttons block - Render custom text color - steps
Buttons block - Render custom background color - steps
Buttons block - Render gradient background color - steps
Buttons block - Check if selection / caret color matches font color - steps
Buttons block - The newly created Buttons has set background color to the theme-default color in preview - steps
- ❌ Found an issue with preview not loading. [Gutenberg] Enable build from monorepo #14188 (comment)

Button-5

Buttons block - Edit text styles - steps
Buttons block - Fallback to default colors in case theme colors are used - steps
Buttons block - Settings: Change Button border radius - steps

Button-6

Buttons block - Settings: Open in new tab - steps
Buttons block - Settings: Link rel - steps
Buttons block - Settings: Link URL - steps
Buttons block - Settings: Remove link - steps
Buttons block - Settings: Synchronize with button options - steps

Button-7

Buttons block - Link from the clipboard is automatically added into the empty URL field in link settings and button options - steps
Buttons block - Toolbar link button is active when Button has link - steps

github-actions · 2020-06-18T13:33:09Z

	Warnings
⚠️	This PR is labelled with 'DO NOT MERGE'. Please don't merge it.

Generated by 🚫 dangerJS against 567a30a

chipsnyder · 2020-06-18T19:13:35Z

This might be a bit random: While running from 36da2018e8a47fdba91396e60350db21891f1c2d with a metro server running Gutenberg-Mobile from try/after-monorepo => 81e4828b410a2f1d46ea6f5455a35f04e86154ff

I noticed that the title gets prepopulated with "Welcome to gutenberg for WP Apps!" for a new post.
Not sure if this is an intentional change or not but I don't see this in develop.

ceyhun · 2020-06-19T15:26:07Z

This might be a bit random: While running from 36da2018e8a47fdba91396e60350db21891f1c2d with a metro server running Gutenberg-Mobile from try/after-monorepo => 81e4828b410a2f1d46ea6f5455a35f04e86154ff

I noticed that the title gets prepopulated with "Welcome to gutenberg for WP Apps!" for a new post.
Not sure if this is an intentional change or not but I don't see this in develop.

It's intentional for the demo apps as mentioned here:

When running the "enhanced" gutenberg mobile you should see "Welcome to gutenberg for WP apps" as the post title while it should just display "Welcome to gutenberg" for the core version.

but shouldn't be the case for WP apps, it's probably because we're missing a check in the gutenberg-mobile PR, in this file: https://github.com/wordpress-mobile/gutenberg-mobile/pull/2172/files#diff-1fdf421c05c1140f6d71444ea2b27638R23

I'll fix it and update the gutenberg-mobile ref here 👍

ceyhun · 2020-06-19T16:15:06Z

@chipsnyder Can you please try again with this new gutenberg-mobile ref

chipsnyder · 2020-06-19T16:46:29Z

@chipsnyder Can you please try again with this new gutenberg-mobile ref

That fixed it. Thanks @ceyhun :)

chipsnyder · 2020-06-19T17:17:26Z

@ceyhun I came across an error when testing
Group - Deep nesting is possible (iOS only) - steps

Following those steps I have:

Group 1
- Paragraph
- Paragraph
- Image
- Group 2
  - Paragraph
  - Group 3

Trying to add to group 3 pops the error here:

Update: Tested this against develop and the issues still exist there. Opened up a new issue wordpress-mobile/gutenberg-mobile#2410

chipsnyder · 2020-06-19T18:06:08Z

While testing Buttons block - The newly created Buttons has set background color to the theme-default color in preview - steps I ran into an issue where the preview is hanging for one of my test sites (verified that this is working on a 15.1 test build)

Update: Tested this against develop and the issues still exist there. Opened up a new issue wordpress-mobile/gutenberg-mobile#2411

….0' into gutenberg/try-enabling-build-from-monorepo

mchowning

Did a quick sanity check and everything looks good to me.

SergioEstevao

Looking good! I smoke test the GB editor writing flow, and all is looking correct.

ceyhun added 3 commits May 26, 2020 14:26

Update source of third party podspecs in monorepo

75a07fd

Update gutenberg pod commit hash

0ad3657

Include submodules for gutenberg related deps

bebc910

ceyhun requested review from cameronvoell and Tug May 26, 2020 12:56

ceyhun added the Gutenberg Editing and display of Gutenberg blocks. label May 26, 2020

Add react-native-get-random-values to gutenberg dependencies

e1564e7

Tug mentioned this pull request May 27, 2020

Target gutenberg monorepo branch wordpress-mobile/gutenberg-mobile#2172

Merged

22 tasks

ceyhun added the [Status] DO NOT MERGE label May 29, 2020

Tug marked this pull request as ready for review June 1, 2020 09:55

Tug added this to the Someday milestone Jun 1, 2020

ceyhun added 2 commits June 18, 2020 14:54

Update gutenberg-mobile ref

54a517c

Merge branch 'develop' into gutenberg/try-enabling-build-from-monorepo

7c05788

Update gutenberg-mobile ref

36da201

Update gutenberg-mobile ref

e1f3941

SergioEstevao self-requested a review June 19, 2020 12:26

Update gutenberg-mobile ref

d0c102a

mchowning changed the base branch from develop to gutenberg/integrate_release_1.31.0 June 23, 2020 20:14

Update Podfile's gutenberg ref to bring in monorepo changes

ca40c71

Merge remote-tracking branch 'origin/gutenberg/integrate_release_1.31…

567a30a

….0' into gutenberg/try-enabling-build-from-monorepo

mchowning approved these changes Jun 23, 2020

View reviewed changes

SergioEstevao approved these changes Jun 23, 2020

View reviewed changes

mchowning merged commit 95f2f1a into gutenberg/integrate_release_1.31.0 Jun 23, 2020

mchowning deleted the gutenberg/try-enabling-build-from-monorepo branch June 23, 2020 21:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Gutenberg] Enable build from monorepo #14188

[Gutenberg] Enable build from monorepo #14188

ceyhun commented May 26, 2020 •

edited by cameronvoell

Loading

peril-wordpress-mobile bot commented May 26, 2020 •

edited

Loading

peril-wordpress-mobile bot commented May 26, 2020 •

edited

Loading

peril-wordpress-mobile bot commented May 29, 2020 •

edited

Loading

chipsnyder commented Jun 15, 2020 •

edited

Loading

github-actions bot commented Jun 18, 2020 •

edited

Loading

chipsnyder commented Jun 18, 2020 •

edited

Loading

ceyhun commented Jun 19, 2020

ceyhun commented Jun 19, 2020

chipsnyder commented Jun 19, 2020

chipsnyder commented Jun 19, 2020 •

edited

Loading

chipsnyder commented Jun 19, 2020 •

edited

Loading

mchowning left a comment

SergioEstevao left a comment

[Gutenberg] Enable build from monorepo #14188

[Gutenberg] Enable build from monorepo #14188

Conversation

ceyhun commented May 26, 2020 • edited by cameronvoell Loading

Description

Related PR's:

Gutenberg Monorepo PR's for fixing WPiOS build

peril-wordpress-mobile bot commented May 26, 2020 • edited Loading

peril-wordpress-mobile bot commented May 26, 2020 • edited Loading

peril-wordpress-mobile bot commented May 29, 2020 • edited Loading

chipsnyder commented Jun 15, 2020 • edited Loading

github-actions bot commented Jun 18, 2020 • edited Loading

chipsnyder commented Jun 18, 2020 • edited Loading

ceyhun commented Jun 19, 2020

ceyhun commented Jun 19, 2020

chipsnyder commented Jun 19, 2020

chipsnyder commented Jun 19, 2020 • edited Loading

chipsnyder commented Jun 19, 2020 • edited Loading

mchowning left a comment

Choose a reason for hiding this comment

SergioEstevao left a comment

Choose a reason for hiding this comment

ceyhun commented May 26, 2020 •

edited by cameronvoell

Loading

peril-wordpress-mobile bot commented May 26, 2020 •

edited

Loading

peril-wordpress-mobile bot commented May 26, 2020 •

edited

Loading

peril-wordpress-mobile bot commented May 29, 2020 •

edited

Loading

chipsnyder commented Jun 15, 2020 •

edited

Loading

github-actions bot commented Jun 18, 2020 •

edited

Loading

chipsnyder commented Jun 18, 2020 •

edited

Loading

chipsnyder commented Jun 19, 2020 •

edited

Loading

chipsnyder commented Jun 19, 2020 •

edited

Loading