Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search bar: update border color when dark/light mode toggled. #13625

Merged
merged 3 commits into from
Mar 11, 2020

Conversation

ScoutHarris
Copy link
Contributor

Fixes #13364

This fixes the border color of the Search bar when light/dark mode toggled.

To test:

  • Go to any view with a Search bar. (ex: Site Pages, Blog Posts, Themes)
  • Switch between light and dark modes.
  • Verify the Search bar border color is updated accordingly.

search_bar_border

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ScoutHarris ScoutHarris added the UI User interface bugs label Mar 10, 2020
@ScoutHarris ScoutHarris added this to the 14.5 milestone Mar 10, 2020
@ScoutHarris ScoutHarris self-assigned this Mar 10, 2020
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Mar 10, 2020

You can trigger an installable build for these changes by visiting CircleCI here.

Copy link
Contributor

@mindgraffiti mindgraffiti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahhh thank you. That border was really noticeable 😀

✅ code
✅ UI tested

@ScoutHarris ScoutHarris merged commit b1eacb8 into develop Mar 11, 2020
@ScoutHarris ScoutHarris deleted the fix/13364-search_bar_border branch March 11, 2020 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UI User interface bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pages & Posts lists: Search border incorrect color when switching appearance
2 participants