Fix post status issues in Scheduling screen #13591
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You can trigger an installable build for these changes by visiting CircleCI here. |
|
Hey there! I'm moving this to 14.5 because 14.4 has just been cut. If you want this to make it to 14.4, please feel free to ping me! |
ScoutHarris
approved these changes
Mar 10, 2020
There was a problem hiding this comment.
Hey @bjtitus .
This seems to work as intended. After updating the release note, 
RELEASE-NOTES.txt
Outdated
| @@ -1,6 +1,7 @@ | |||
| 14.4 | |||
| ----- | |||
| * Post Settings: Fixes the displayed publish date of posts which are to be immediately published. | |||
| * Post Settings: Fix issue where the status of a post showed "Scheduled" instead of "Published" after scheduling before the current date. | |||
There was a problem hiding this comment.
Just a note to move this to 14.5.
|
@bjtitus , currently in 14.5 beta and develop we are not able to set a past date for a post please look at this issue @designsimply created and the videos in it. I'm experiencing the same issue. cc: @bummytime |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #13586
Consolidates the logic for converting a Post to the proper PublishSettingsViewModel status and adds unit tests.
To test:
PR submission checklist:
RELEASE-NOTES.txtif necessary.