Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dark Mode] Posts list: Re-set ghost style when switching filter tabs. #13365

Merged
merged 1 commit into from
Feb 4, 2020

Conversation

ScoutHarris
Copy link
Contributor

@ScoutHarris ScoutHarris commented Feb 4, 2020

Fixes #13326

This fixes an issue where the ghost cells in the Blog Posts list would appear white instead of showing the ghost animation.

Note: there is a separate issue with the Search bar border color.

To test:

  • Set the device to dark mode.
  • On a slow network, go to Blog Posts.
  • Switch between tabs.
  • Verify the ghost cells animate.
Before After
before after

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@ScoutHarris ScoutHarris added Posts + Pages UI User interface bugs labels Feb 4, 2020
@ScoutHarris ScoutHarris added this to the 14.2 milestone Feb 4, 2020
@ScoutHarris ScoutHarris self-assigned this Feb 4, 2020
Copy link
Contributor

@mindgraffiti mindgraffiti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ code
✅ UI tested

:shipit:

@loremattei loremattei added UI User interface bugs and removed UI User interface bugs labels Feb 4, 2020
@ScoutHarris ScoutHarris merged commit c957f3d into develop Feb 4, 2020
@ScoutHarris ScoutHarris deleted the fix/13326-post_list_dark_mode branch February 4, 2020 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Posts + Pages UI User interface bugs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GlobalStep] [Dark Mode] White content placeholders show when switching between different Posts List views
3 participants