-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add autosave attributes to Core Data #12826
Add autosave attributes to Core Data #12826
Conversation
Post autosave properties are now persisted via Core Data to `AbstractPost`.
It is desirable for all post service API calls to fetch autosave data, so `autosave` has been set as the default value for `meta`.
Generated by 🚫 dangerJS |
This allows CircleCI to build the feature branch.
The lock file had to be commited to allow CirclCI do make the build.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, @guarani!
A few things that need to be done before we can merge this:
- Finish discussions in Add autosave attributes to RemotePost WordPressKit-iOS#192
- Increment the WordPressKit pod version. See Add autosave attributes to RemotePost WordPressKit-iOS#192 (comment).
- @shiki Approve and merge WordPressKit PR
- @shiki Create a new release of WordPressKit in Github
- Fix the conflicts in this PR
- Update this branch with the released WordPressKit version.
Version number waiting for @shiki. - @shiki Approve and merge this PR
I marked the items that I'll take care of.
Very helpful list, thanks @shiki! I'll reply to each of my items in turn as I can't mark them off directly due to permissions.
Done ✅
Done ✅
Done ✅
I'll be on this once the new release of WordPressKit is ready. |
@guarani WordPressKit-iOS 4.5.3-beta.2 has been released. You should be able to update the |
r.e. #12826 (review)
@shiki, I've updated this project to point to https://github.com/wordpress-mobile/WordPressKit-iOS/releases/tag/4.5.3-beta.2 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @guarani!
Thank you, @shiki! |
Post autosave attributes are saved to Core Data upon retrieval from the remote service.
Issue: #12141
Related PR: wordpress-mobile/WordPressKit-iOS#192
Although the changes in the WordPressKit PR map all autosave attributes, only those necessary for #12141 are now persisted to Core Data.
Testing Details
WordPress.sqlite
and open a database browser at this locationSELECT ZAUTOSAVETITLE, ZAUTOSAVEEXCERPT, ZAUTOSAVECONTENT, ZAUTOSAVEMODIFIEDDATE FROM ZBASEPOST;
and observe that the title, excerpt, content, and timestamp contain the expected values:RELEASE-NOTES.txt
if necessary.