Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix:Media & Text - Block validation error occurs if media upload finishes when the post is closed #12797

Merged
merged 6 commits into from
Oct 29, 2019
Merged

Fix:Media & Text - Block validation error occurs if media upload finishes when the post is closed #12797

merged 6 commits into from
Oct 29, 2019

Conversation

pinarol
Copy link
Contributor

@pinarol pinarol commented Oct 29, 2019

Fixes wordpress-mobile/gutenberg-mobile#1509

To test:
Follow the steps in the issue

Update release notes:

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@pinarol pinarol added this to the 13.5 ❄️ milestone Oct 29, 2019
@pinarol pinarol requested a review from koke October 29, 2019 09:57
@pinarol pinarol self-assigned this Oct 29, 2019
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Oct 29, 2019 •
edited
Loading

You can test the changes on this Pull Request by downloading it from HockeyApp here. If you need access to this, you can ask a maintainer to add you.

koke
koke approved these changes Oct 29, 2019
View reviewed changes
Copy link
Member

@koke koke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested image, video, and media-text and it's working fine 🎉

etoledom
etoledom approved these changes Oct 29, 2019
View reviewed changes
Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gave it a fast smoke-test. Looks good ✅

@pinarol pinarol merged commit 16c74f6 into gutenberg/hotfix-1.15.2 Oct 29, 2019
@pinarol pinarol deleted the fix/media-text-upload branch October 29, 2019 11:51
@etoledom etoledom mentioned this pull request Oct 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etoledom etoledom etoledom approved these changes

@koke koke koke approved these changes

Assignees

@pinarol pinarol

Labels
None yet
Projects
None yet
Milestone
13.5
Development

Successfully merging this pull request may close these issues.
3 participants
@pinarol @koke @etoledom