Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "support multiple prop in gutenberg editor" #12611

Merged
merged 2 commits into from
Oct 3, 2019
Merged

Revert "support multiple prop in gutenberg editor" #12611

merged 2 commits into from
Oct 3, 2019

Conversation

pinarol
Copy link
Contributor

@pinarol pinarol commented Oct 2, 2019

This reverts changes done by #10556 since we are in a code freeze on gutenberg mobile and this wasn't supposed to get merged during it.

I used git diff bbad25cf34e3130eb4bbc733d6d217710119aaca fa459afd34cd652817ea0224030666eb25d4d121 to compare this branch with the previous commit in develop to make sure this is reverting everything.

This reverts commit a2a5e52.

Fixes #

To test:

Update release notes:

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@pinarol pinarol added the Gutenberg Editing and display of Gutenberg blocks. label Oct 2, 2019
@pinarol pinarol added this to the 13.4 milestone Oct 2, 2019
@pinarol pinarol requested a review from etoledom October 2, 2019 16:07
@pinarol pinarol self-assigned this Oct 2, 2019
etoledom
etoledom approved these changes Oct 3, 2019
View reviewed changes
Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you for handling this 👍

@etoledom etoledom merged commit 9a415e7 into develop Oct 3, 2019
@etoledom etoledom deleted the issue/revert-multiple-media-pr branch October 3, 2019 06:35
etoledom added a commit that referenced this pull request Oct 3, 2019
@etoledom
Revert "Merge pull request #12611 from wordpress-mobile/issue/revert-…
3064a0b 
…multiple-media-pr"

This reverts commit 9a415e7, reversing
changes made to d3ac4a0.
@etoledom etoledom mentioned this pull request Oct 3, 2019
Merged
1 task
pinarol pushed a commit that referenced this pull request Oct 8, 2019
@etoledom @pinarol
[Gutenberg] Revert "revert-multiple-media-pr" (#12615)
5d73639 
* Revert "Merge pull request #12611 from wordpress-mobile/issue/revert-multiple-media-pr"

This reverts commit 9a415e7, reversing
changes made to d3ac4a0.

* Update gutenberg ref
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etoledom etoledom etoledom approved these changes

Assignees

@pinarol pinarol

Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Milestone
13.4
Development

Successfully merging this pull request may close these issues.
2 participants
@pinarol @etoledom