Revert fix for Discard losing changes in develop #11924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
yaelirub
approved these changes
Jun 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completely reverts the fixes for #11435.
This reverts the PRs #11898 and #11736. They caused the Editor to discard the contents when pressing the Update button while offline, both for drafts and published posts. This was found while finding the solution for #11905.
The #11736 was already reverted for
release/12.6in #11920.Proposal
As I commented in #11435 (comment), we still need to fix the #11435 issue but we should wait until the discussion in wordpress-mobile/WordPress-Android#9561 is finished so the iOS and Android solutions will match.
Testing
Please also test other statuses like published or when online.
Release Notes
RELEASE-NOTES.txt.