Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gutenberg]Disable editing menu on post title #11275

Merged
merged 5 commits into from
Mar 15, 2019

Conversation

pinarol
Copy link
Contributor

@pinarol pinarol commented Mar 14, 2019

Fixes wordpress-mobile/gutenberg-mobile#725

To test:
Follow steps on wordpress-mobile/gutenberg-mobile#747

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@pinarol pinarol added the Gutenberg Editing and display of Gutenberg blocks. label Mar 14, 2019
@pinarol pinarol added this to the 12.1 milestone Mar 14, 2019
@pinarol pinarol self-assigned this Mar 14, 2019
@pinarol pinarol requested a review from etoledom March 14, 2019 15:47
Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working great! 🎉
Tested via wordpress-mobile/gutenberg-mobile#747 (review)

  • I did have to keep metro running to see the changes. But the native changes doesn't break the current JS Bundle, so I'd say that a new bundle is not necessary.

@pinarol pinarol merged commit c82442e into develop Mar 15, 2019
@pinarol pinarol deleted the gutenberg/disable-editing-menu-on-title branch March 15, 2019 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants