Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gutenberg settings tracking #11043

Merged
merged 4 commits into from
Feb 14, 2019

Conversation

koke
Copy link
Member

@koke koke commented Feb 14, 2019

Adds the Gutenberg setting tracking described on wordpress-mobile/gutenberg-mobile#556:

  • App setting to enable Gutenberg: gutenberg_enabled when switched on, gutenberg_disabled when switched off.
  • Add a gutenberg_enabled property to the user properties that are sent with every event.

To test:

The best way to test the events is to look at the logs, but it gets too noisy with React Native. You can edit the Xcode scheme, and in Run > Arguments enable the OS_ACTIVITY_MODE=disable environment variable. You can also search for 🔵 in the log but that would filter out the event properties 😞

You can't see the userProperties in the logs, so you can add a breakpoint and inspect self.tracksService.userProperties

debug-user-properties

Also, it's a good idea to do a final check and see if the expected events made it into the backend, you might have to wait ~5 minutes for those to appear.

cc @hypest

@koke koke added Analytics Gutenberg Editing and display of Gutenberg blocks. labels Feb 14, 2019
@koke koke added this to the 11.9 milestone Feb 14, 2019
@koke koke requested a review from etoledom February 14, 2019 14:15
Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🎉

  • Code looks shinny and Xcode shows that everything is working.
  • Both events and the property are arriving correctly to Tracks ✅

@koke koke merged commit 0e64a4e into develop Feb 14, 2019
@koke koke deleted the issue/gutenberg-mobile-556-gutenberg-settings-events branch February 14, 2019 15:27
@peril-wordpress-mobile
Copy link

Danger run resulted in 1 fail and 1 markdown; to find out more, see the checks page.

Generated by 🚫 dangerJS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Analytics Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants