Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the Gutenberg setting tracking described on wordpress-mobile/gutenberg-mobile#556:
gutenberg_enabled
when switched on,gutenberg_disabled
when switched off.gutenberg_enabled
property to the user properties that are sent with every event.To test:
The best way to test the events is to look at the logs, but it gets too noisy with React Native. You can edit the Xcode scheme, and in Run > Arguments enable the
OS_ACTIVITY_MODE=disable
environment variable. You can also search for🔵
in the log but that would filter out the event properties 😞You can't see the userProperties in the logs, so you can add a breakpoint and inspect
self.tracksService.userProperties
Also, it's a good idea to do a final check and see if the expected events made it into the backend, you might have to wait ~5 minutes for those to appear.
cc @hypest