Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PPP: Set parent page analytics #10463

Merged
merged 5 commits into from
Nov 16, 2018
Merged

PPP: Set parent page analytics #10463

merged 5 commits into from
Nov 16, 2018

Conversation

danielebogo
Copy link
Contributor

This PR adds 3 new Analytics events to the Set Parent page view controller.
The new events are:

  • site_pages_set_parent_viewed: When the VC appears
  • site_pages_set_parent_search_accessed: When the set parent search is accessed
  • site_pages_set_parent_done_pressed: When the done button is pressed

To test:

  • Select a Blog -> Site pages -> click the ••• menu on a page and open the set parent view controller.
  • You should be able to see the tracked events on your console

@danielebogo danielebogo added this to the 11.3 milestone Nov 15, 2018
@danielebogo danielebogo self-assigned this Nov 15, 2018
@danielebogo danielebogo requested review from a user, jklausa and SylvesterWilmott November 15, 2018 15:09
jklausa
jklausa approved these changes Nov 16, 2018
View reviewed changes
Copy link
Contributor

@jklausa jklausa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised! :shipit:

(and sorry for the merge conflicts ;f)

@danielebogo danielebogo merged commit 96b8a0d into develop Nov 16, 2018
@danielebogo danielebogo deleted the issues/ppp-analytics branch November 16, 2018 14:40
@designsimply designsimply mentioned this pull request Dec 23, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklausa jklausa jklausa approved these changes

@SylvesterWilmott SylvesterWilmott Awaiting requested review from SylvesterWilmott

Assignees

@danielebogo danielebogo

Labels
Analytics
Projects
None yet
Milestone
11.3
Development

Successfully merging this pull request may close these issues.
2 participants
@danielebogo @jklausa