Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menus screen enters an infinite loop of loading site's pages #21947

Closed
crazytonyli opened this issue Nov 2, 2023 · 0 comments · Fixed by #21949
Closed

Menus screen enters an infinite loop of loading site's pages #21947

crazytonyli opened this issue Nov 2, 2023 · 0 comments · Fixed by #21949
Assignees
Labels
Menus MTTR-inclusion A label telling that issue will be included into MTTR calculation. [Type] Bug

Comments

@crazytonyli
Copy link
Contributor

crazytonyli commented Nov 2, 2023

Expected behavior & Actual behavior

When a site does not have any menu, the Menus screen fetches all pages in the site and creates menu items for each top level page. The API requests to load all pages should stop once all pages are loaded. But it doesn't stop. The API request continues to fire.

The infinity loading causes the "default menu" section the Menu screen staying at "loading menus" state.

Steps to reproduce the behavior

To reproduce this bug, prepare a site that doesn't have any menu, like a brand new WP.com site. Add a couple of pages to the site.

  1. Adds a log at this line in PostService
  2. Launch the app from Xcode and go to the prepared site from the app.
  3. Go to the Menu screen (My Site -> More -> Menu)
  4. Check out Xcode's console output. The log added at step 1 will keep printing in the console.
Tested on [device], iOS [version], Jetpack iOS / WordPress iOS [version]

c2493d9

@crazytonyli crazytonyli self-assigned this Nov 2, 2023
@pachlava pachlava added the MTTR-inclusion A label telling that issue will be included into MTTR calculation. label Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Menus MTTR-inclusion A label telling that issue will be included into MTTR calculation. [Type] Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants