-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WPMediaPickerViewController crash: NSInternalInconsistencyException: Invalid batch updates detected #21102
WPMediaPickerViewController crash: NSInternalInconsistencyException: Invalid batch updates detected #21102
Comments
On WordPress, this gets grouped into WORDPRESS-IOS-38W2. I ran into this issue while smoke testing Note: I could not reproduce this issue on a simulator. Device: iPhone SE (3rd generation)
Videomedia_crash.mp4 |
I tried to reproduce it on an iPad 7th gen with iPadOS 16.5.1 and couldn't (don't have an iPhone to double check though but I see in the listed devices for the issue there are iPads so maybe there is some other bit in the testing scenario that I do not have on my side). |
I tried to reproduce several times on an iPad 9th gen iPadOS 16.3.1 without success, moved to the iPhone 13 iOS 16.5.1 and faced the crash in the first try. Jetpack version was |
Increasing the priority of the task, since it became the most frequent crash for 22.8 in the last 24 hours and the third most frequent crash for all versions in the last 24 hours. |
👋 I ran into this just now but in a different flow than the one described above in #21102 (comment). However, I couldn't reproduce it again so here are the steps I recall taking leading up to the crash:
|
I reproduced the crash by accident on my testing site. It seems to be happening consistently. I invited you as an admin to the site so you can test. Steps to reproduce:
Strack trace
|
There was a steep rise of these crashes in 22.8.0.3. I posted in the respective channel p1690817991010719-slack-C012H19SZQ8. |
Tested the crash with the site that has a 100% crash rate: 22.7 - No crash The most apparent difference between 22.7 and 22.8 was an update of WPMediaPicker . This was the only PR between 22.7 and 22.8. I reverted the change in the media picker and re-tested locally - No crash Fix crash when displaying an empty view is a root cause for this crash. |
@staskus can you invite me to your site? 🙏 |
@hassaanelgarem of course, done! I tested on iPhone 14 Pro and after fresh install I get a crash 100%. From the first look I couldn't understand why that particular fix could result in a crash in this case. |
I tested on CleanShot.2023-08-01.at.11.55.20.mp4 |
There're some indications that it could be related to iOS updates iOS 16.4.1 - UICollectionViewController crashes Apple Frameworks Engineer indicates:
Possibly related discussions: pbzQyC-3U2-p2, pbzQyC-3SP-p2 |
Sentry reports two further crashes in 22.9. Could you please take a look @staskus and re-open this if necessary? |
These are rarer crashes happening in a bit different place. There were most crashes in I applied the same temporary fix, we can try merging them to release/23.0: |
Sentry says this issue regressed but the only occurrence in 23.0 seems like a different crash. Instead of |
I noticed that this last occurrence seems to be Reader or Notification so it's probably wrongly grouped by Sentry. There are some ideas for changing the grouping behavior here, https://docs.sentry.io/product/data-management-settings/event-grouping/, but I haven't explored it.
I agree 👍 |
Sentry Issue: JETPACK-IOS-FQW
The text was updated successfully, but these errors were encountered: