-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tapping widget does not deep link to Stats view until Stats view is manually loaded #18452
Comments
Related WPAndroid issue: |
Thanks for adding this and the matching Android issue, @twstokes! I'm curious, how did this come up? E.g. did you come across it, or was it reported somewhere by a user? |
👋 @guarani! This was sparked from this internal convo from Happiness: p1650977038487969-slack-C011BKNU1V5 |
Thanks for sharing @twstokes! 👋 @sla8c, could you please check if this and the related Android issue are regressions (i.e. bugs), or indeed enhancement issues as they've been designated here? There might be more info on internal P2s, but feel free to ask the team for help. Alternatively, older versions of the app from when stats was released could be tested to verify previous behavior. 🙇 |
Hi @twstokes @guarani I've tested iOS 19.5 and 19.4 and it's not a regression. On iOS + today widget there is a site selection option when editing the widget so it seems like that was always the intent? However I haven't looked for / found the GH issues / PRs / done P2s search yet. On Android I tested version 19.2 and it's not a regression either. @guarani just one note the link above re: "related Android issue" is pointed to the iOS issue. I took a look in https://github.com/wordpress-mobile/WordPress-Android/ and I don't see an issue with "deep link widget" |
👋 @sla8c - here's a direct link to the related Android issue. @guarani's link goes to the comment above that links to the same location. 👍 Thanks for doing the research on this! |
Hi @sla8c, thanks for checking. Based on what you're saying, I tested iOS and Android and the behavior on iOS seems correct, it's only Android that has a bug:
iOS screen recordingThe video below shows that each widget opens the Stats screen of site its configured to show stats for. The names of the sites on the widgets match the site names shown after opening stats. RPReplay_Final1651160482.MP4Android screen recordingThe video below shows that each widget opens the Stats screen of the default site for the logged-in account. Note that unlike iOS, Android widgets don't seem to show the site name, so it's a bit harder to follow what's going on. Screen_Recording_20220428-114634_WordPress.mp4👋 @twstokes, could you please correct me if I'm missing something? So far, everything seems to work as expected on iOS, but I can reproduce the issue on Android.
Sorry for the confusion, @sla8c! The link points to an earlier comment on this issue which in-turn links to the Android issue. |
Thanks @guarani and @sla8c for looking into this. 🙇
This is not what I experienced when I added the ticket, so I think we're dealing with a bug related to #17567. RPReplay_Final1651166882.MP4Once I visited the Stats view for that site from WPiOS immediately after recording this video, tapping the widget took me to the Stats view. Sorry for the confusion, I'll update this issue's description. 👍 |
@guarani I updated this ticket to reflect my current understanding. Even though it appears related to #17567, I'm not sure why I didn't see the "Unable to load site stats" message in the first place. I set the priority for this issue to low due to medium severity (has a workaround) and low impact (my estimate based on widgets usage, though I didn't find stats to back that up). |
Thanks for the update, @twstokes! Looking at the video, there definitely seems to be an issue. Can you reproduce this issue consistently? This issue and #17567 seem to have the same steps to reproduce, but different "actual behaviors" message. When I log into the app, and add the widget, I see the "Unable to load site stats". It sounds like when you do the same, the widget loads i.e. you're unable to reproduce #17567 – is that correct? |
I've found a way to reproduce this consistently on my test device, so I'll update this issue again to match that. RPReplay_Final1651170886.MP4
|
I can now reproduce, thanks so much @twstokes! (Given the potential overlap between this issue and #17567, I added a note to that issue saying that tapping on the widget when it's displaying "Unable to load site stats" does not open the stats screen.) Regarding this issue, the key step I was missing when trying to reproduce this was to close the app (step 8 above). I agree with the Low priority given to this issue, because there is a workaround and we've only had one user report that I'm aware of. Let's leave this unassigned for now 👍 |
Expected behavior
Actual behavior
RPReplay_Final1651170886.MP4
Steps to reproduce the behavior
Tested on iPhone 12, iOS 15.4.1, WPiOS 19.7.0.2
The text was updated successfully, but these errors were encountered: