Add localizable name for WordPress app on App Store (#18120)

wordpress-mobile · Mar 11, 2022 · d328080 · d328080
2 parents bbee2a8 + d96bc80
commit d328080
Show file tree

Hide file tree

Showing 7 changed files with 14 additions and 1 deletion.
diff --git a/WordPress/Resources/AppStoreStrings.po b/WordPress/Resources/AppStoreStrings.po
@@ -13,6 +13,11 @@ msgstr ""
 "Last-Translator: \n"
 "Language-Team: \n"
 
+#. translators: The application name in the Apple App Store. Please keep the brand name ('WordPress') verbatim. Limit to 30 characters including spaces and punctuation!
+msgctxt "app_store_name"
+msgid "WordPress – Website Builder"
+msgstr ""
+
 #. translators: Subtitle to be displayed below the application name in the Apple App Store. Limit to 30 characters including spaces and commas!
 msgctxt "app_store_subtitle"
 msgid "Design a site, build a blog"

diff --git a/fastlane/Fastfile b/fastlane/Fastfile
@@ -204,6 +204,7 @@ platform :ios do
 
     files = {
       whats_new: File.join(PROJECT_ROOT_FOLDER, 'WordPress', 'Resources', 'release_notes.txt'),
+      app_store_name: File.join(source_metadata_folder, 'name.txt'),
       app_store_subtitle: File.join(source_metadata_folder, 'subtitle.txt'),
       app_store_desc: File.join(source_metadata_folder, 'description.txt'),
       app_store_keywords: File.join(source_metadata_folder, 'keywords.txt'),

diff --git a/fastlane/Jetpack-Fastfile b/fastlane/Jetpack-Fastfile
@@ -145,7 +145,7 @@ lane :update_jetpack_appstore_strings do |options|
     'screenshot-text-4' => File.join(source_metadata_folder, 'promo_screenshot_4.txt'),
     'screenshot-text-5' => File.join(source_metadata_folder, 'promo_screenshot_5.txt'),
     'screenshot-text-6' => File.join(source_metadata_folder, 'promo_screenshot_6.txt'),
-    'app-store-name' => File.join(source_metadata_folder, 'app_name.txt')
+    app_store_name: File.join(source_metadata_folder, 'name.txt')
   }
 
   ios_update_metadata_source(

diff --git a/...eres/jetpack_metadata/source/app_name.txt → ...storeres/jetpack_metadata/source/name.txt b/...eres/jetpack_metadata/source/app_name.txt → ...storeres/jetpack_metadata/source/name.txt
diff --git a/fastlane/appstoreres/metadata/source/name.txt b/fastlane/appstoreres/metadata/source/name.txt
@@ -0,0 +1 @@
+WordPress – Website Builder
diff --git a/fastlane/download_metadata.swift b/fastlane/download_metadata.swift
@@ -2,6 +2,7 @@
 
 import Foundation
 
+let glotPressNameKey = "app_store_name"
 let glotPressSubtitleKey = "app_store_subtitle"
 let glotPressWhatsNewKey = "v19.4-whats-new"
 let glotPressDescriptionKey = "app_store_desc"
@@ -90,6 +91,7 @@ func downloadTranslation(
                 return
         }
 
+        var name: String?
         var subtitle: String?
         var whatsNew: String?
         var keywords: String?
@@ -114,6 +116,8 @@ func downloadTranslation(
             let translation = languageCode == "en-us" ? originalLanguage : firstValue
 
             switch keyFirstPart {
+            case glotPressNameKey:
+                name = translation
             case glotPressSubtitleKey:
                 subtitle = translation
             case glotPressKeywordsKey:
@@ -141,6 +145,7 @@ func downloadTranslation(
                 try FileManager.default.removeItem(at: URL(fileURLWithPath: releaseNotesPath))
             }
 
+            try name?.write(toFile: "\(languageFolder)/name.txt", atomically: true, encoding: .utf8)
             try subtitle?.write(toFile: "\(languageFolder)/subtitle.txt", atomically: true, encoding: .utf8)
             try whatsNew?.write(toFile: "\(languageFolder)/release_notes.txt", atomically: true, encoding: .utf8)
             try keywords?.write(toFile: "\(languageFolder)/keywords.txt", atomically: true, encoding: .utf8)

diff --git a/fastlane/metadata/default/name.txt b/fastlane/metadata/default/name.txt
@@ -0,0 +1 @@
+WordPress – Website Builder