Merge pull request #20998 from wordpress-mobile/fix-memory-leak-in-no…

…tification-observers-4 Capture weak references in some notification observers
wordpress-mobile · Jul 4, 2023 · c55f6ab · c55f6ab
2 parents 99c5e0a + 36b961f
commit c55f6ab
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/...ss/Classes/ViewRelated/Gutenberg/Collapsable Header/CollapsableHeaderViewController.swift b/...ss/Classes/ViewRelated/Gutenberg/Collapsable Header/CollapsableHeaderViewController.swift
@@ -759,19 +759,22 @@ extension CollapsableHeaderViewController: UIScrollViewDelegate {
 // MARK: - Keyboard Adjustments
 extension CollapsableHeaderViewController {
     private func startObservingKeyboardChanges() {
-        let willShowObserver = NotificationCenter.default.addObserver(forName: UIResponder.keyboardWillShowNotification, object: nil, queue: .main) { (notification) in
+        let willShowObserver = NotificationCenter.default.addObserver(forName: UIResponder.keyboardWillShowNotification, object: nil, queue: .main) { [weak self] (notification) in
+            guard let self else { return }
             UIView.animate(withKeyboard: notification) { (_, endFrame) in
                 self.scrollableContainerBottomConstraint.constant = endFrame.height - self.footerHeight
             }
         }
 
-        let willHideObserver = NotificationCenter.default.addObserver(forName: UIResponder.keyboardWillHideNotification, object: nil, queue: .main) { (notification) in
+        let willHideObserver = NotificationCenter.default.addObserver(forName: UIResponder.keyboardWillHideNotification, object: nil, queue: .main) { [weak self] (notification) in
+            guard let self else { return }
             UIView.animate(withKeyboard: notification) { (_, _) in
                 self.scrollableContainerBottomConstraint.constant = 0
             }
         }
 
-        let willChangeFrameObserver = NotificationCenter.default.addObserver(forName: UIResponder.keyboardWillChangeFrameNotification, object: nil, queue: .main) { (notification) in
+        let willChangeFrameObserver = NotificationCenter.default.addObserver(forName: UIResponder.keyboardWillChangeFrameNotification, object: nil, queue: .main) { [weak self] (notification) in
+            guard let self else { return }
             UIView.animate(withKeyboard: notification) { (_, endFrame) in
                 self.scrollableContainerBottomConstraint.constant = endFrame.height - self.footerHeight
             }