Skip to content

Commit

Permalink
Fix duplicate localization keys (#23123)
Browse files Browse the repository at this point in the history
  • Loading branch information
staskus authored May 1, 2024
2 parents 13b701d + b1bfff4 commit c0f5f84
Show file tree
Hide file tree
Showing 4 changed files with 15 additions and 8 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ private extension SubmitFeedbackViewController {
)

static let submitLoadingAnonymouslyMessage = NSLocalizedString(
"submit.feedback.submit.loading",
"submit.feedback.submitAnonymously.loading",
value: "Sending anonymously",
comment: "Notice informing user that their feedback is being submitted anonymously."
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ extension PeopleViewController {
case .viewers:
return NSLocalizedString("Viewers", comment: "Blog Viewers")
case .email:
return NSLocalizedString("users.list.title.subscribers", value: "Email Subscribers", comment: "Site Email Subscribers")
return NSLocalizedString("users.list.title.emailSubscribers", value: "Email Subscribers", comment: "Site Email Subscribers")
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ extension ReaderSiteTopic {
}

let emptyTitle = NSLocalizedString(
"reader.no.tags.title",
"reader.no.blog.title",
value: "Add a blog",
comment: "No Tags View Button Label"
)
Expand Down
17 changes: 12 additions & 5 deletions WordPress/Resources/en.lproj/Localizable.strings
Original file line number Diff line number Diff line change
Expand Up @@ -7608,6 +7608,9 @@ with the filter chip button. */
/* Reader settings button accessibility label. */
"reader.navigation.settings.button.label" = "Reader Settings";

/* No Tags View Button Label */
"reader.no.blog.title" = "Add a blog";

/* Title for button on the no followed blogs result screen */
"reader.no.blogs.button" = "Discover Blogs";

Expand All @@ -7633,7 +7636,7 @@ with the filter chip button. */
"reader.no.results.subscriptions.button" = "Go to Subscriptions";

/* No Tags View Button Label */
"reader.no.tags.title" = "Add a blog";
"reader.no.tags.title" = "Add a tag";

/* Notice title when blocking a blog fails. */
"reader.notice.blog.blocked.failure" = "Unable to block blog";
Expand Down Expand Up @@ -9573,10 +9576,12 @@ Refer to: `reader.preferences.preview.body.feedback.format` */
/* The button title for the Submit button in the In-App Feedback screen */
"submit.feedback.submit.button" = "Submit";

/* Notice informing user that their feedback is being submitted anonymously.
Notice informing user that their feedback is being submitted. */
/* Notice informing user that their feedback is being submitted. */
"submit.feedback.submit.loading" = "Sending";

/* Notice informing user that their feedback is being submitted anonymously. */
"submit.feedback.submitAnonymously.loading" = "Sending anonymously";

/* The title for the the In-App Feedback screen */
"submit.feedback.title" = "Feedback";

Expand Down Expand Up @@ -10962,8 +10967,10 @@ Refer to: `reader.preferences.preview.body.feedback.format` */
/* Blog Users */
"Users" = "Users";

/* Site Email Subscribers
Site Subscribers */
/* Site Email Subscribers */
"users.list.title.emailSubscribers" = "Email Subscribers";

/* Site Subscribers */
"users.list.title.subscribers" = "Subscribers";

/* Menus label for describing which menu the location uses in the header. */
Expand Down

0 comments on commit c0f5f84

Please sign in to comment.