Skip to content

Commit

Permalink
Ensure downloaded .strings files are committed
Browse files Browse the repository at this point in the history
And update other "`.strings` update" commit message to differentiate the two steps
  • Loading branch information
AliSoftware committed Mar 24, 2022
1 parent 6894fba commit 9eb7407
Showing 1 changed file with 12 additions and 2 deletions.
14 changes: 12 additions & 2 deletions fastlane/lanes/localization.rb
Original file line number Diff line number Diff line change
Expand Up @@ -195,13 +195,23 @@
locales: GLOTPRESS_TO_LPROJ_APP_LOCALE_CODES,
download_dir: parent_dir_for_lprojs
)
git_commit(
path: File.join(parent_dir_for_lprojs, '*.lproj', 'Localizable.strings'),
message: 'Update app translations – `Localizable.strings`',
allow_nothing_to_commit: true
)

# Then redispatch the appropriate subset of translations back to the `InfoPlist.strings` and `Sites.strings` files in corresponding `*.lproj` dirs
# Redispatch the appropriate subset of translations back to the manually-maintained `.strings`
# files that we previously merged via `ios_merge_strings_files` during `complete_code_freeze`
modified_files = ios_extract_keys_from_strings_files(
source_parent_dir: parent_dir_for_lprojs,
target_original_files: MANUALLY_MAINTAINED_STRINGS_FILES
)
git_commit(path: modified_files, message: 'Update app translations', allow_nothing_to_commit: true)
git_commit(
path: modified_files,
message: 'Update app translations – Other `.strings`',
allow_nothing_to_commit: true
)

# Finally, also download the AppStore metadata (app title, keywords, etc.)
# @FIXME: Replace this whole lane with a call to the future replacement of `gp_downloadmetadata` once it's implemented in the release-toolkit (see paaHJt-31O-p2).
Expand Down

0 comments on commit 9eb7407

Please sign in to comment.