Skip to content

Commit

Permalink
Move the WebKitView dismissed tracking to viewWillDisappear
Browse files Browse the repository at this point in the history
  • Loading branch information
emilylaguna committed Nov 30, 2021
1 parent 86a06d4 commit 3cc23e5
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions WordPress/Classes/Utility/WebKitViewController.swift
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,8 @@ class WebKitViewController: UIViewController, WebKitAuthenticatable {
super.viewWillDisappear(animated)
stopWaitingForConnectionRestored()
ReachabilityUtils.dismissNoInternetConnectionNotice()

track(.webKitViewDismissed)
}

@objc func loadWebViewRequest() {
Expand Down Expand Up @@ -394,10 +396,8 @@ class WebKitViewController: UIViewController, WebKitAuthenticatable {
}

// MARK: User Actions

@objc func close() {
dismiss(animated: true, completion: onClose)
track(.webKitViewDismissed)
}

@objc func share() {
Expand Down

0 comments on commit 3cc23e5

Please sign in to comment.