Skip to content

Commit

Permalink
Update text alignments for header
Browse files Browse the repository at this point in the history
  • Loading branch information
alpavanoglu committed Feb 24, 2023
1 parent 6453e6e commit 10bf279
Showing 1 changed file with 14 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,19 @@ final class WebAddressWizardContent: CollapsableHeaderViewController {
WPAnalytics.track(.enhancedSiteCreationDomainsAccessed)
loadHeaderView()
addAddressHintView()
configureUIIfNeeded()
}

private func configureUIIfNeeded() {
guard FeatureFlag.siteCreationDomainPurchasing.enabled else {
return
}

NSLayoutConstraint.activate([
largeTitleView.widthAnchor.constraint(equalTo: headerStackView.widthAnchor)
])
largeTitleView.textAlignment = .natural
promptView.textAlignment = .natural
}

private func loadHeaderView() {
Expand Down Expand Up @@ -423,7 +436,7 @@ final class WebAddressWizardContent: CollapsableHeaderViewController {
comment: "Displayed during Site Creation, when searching for Verticals and the server returns an error.")
static let mainTitle: String = NSLocalizedString("Choose a domain",
comment: "Select domain name. Title")
static let prompt: String = NSLocalizedString("This is where people will find you on the internet.",
static let prompt: String = NSLocalizedString("Search for a short and memorable keyword to help people find and visit your website.",
comment: "Select domain name. Subtitle")

This comment has been minimized.

Copy link
@mokagio

mokagio Apr 3, 2023

Contributor

I noticed this while checking the new .strings in #20462.

@alpavanoglu when updating localized strings, it would be great to ensure they use reverse-DNS keys to avoid issues such as #19028.

Admittedly, it's highly unlikely we'll duplicated this particular key. Still, there is value in using reverse-DNS key notation consistently.

Thanks!

static let createSite: String = NSLocalizedString("Create Site",
comment: "Button to progress to the next step")
Expand Down

0 comments on commit 10bf279

Please sign in to comment.