Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make objective field nullable #3105

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Conversation

JorgeMucientes
Copy link
Contributor

Makes objective field nullable to avoid sending objective = "" values when attempting to create a Blaze campaign from Woo mobile. Sending objective = "" will make the API request fail.

@JorgeMucientes JorgeMucientes requested a review from irfano October 3, 2024 17:13
@JorgeMucientes JorgeMucientes changed the title Revert accidentally committed change Make objective field nullable Oct 3, 2024
Copy link
Member

@irfano irfano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏻

@irfano irfano self-assigned this Oct 3, 2024
@irfano irfano merged commit 7ad6ce4 into trunk Oct 3, 2024
13 checks passed
@irfano irfano deleted the fix/make-objective-field-nullable branch October 3, 2024 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants