-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ExPlat: Add support to experiment_names parameter #1970
Conversation
val result = experimentStore.fetchAssignments(platform, anonymousId) | ||
val result = experimentStore.fetchAssignments(platform, experimentNames, anonymousId) | ||
result.assignments.variations // Contained variations for experiments which were currently running | ||
result.assignments.variations // Contains variations only for the requests experiments |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I understand these two lines. They are exactly the same and don't do anything with the value. What am I missing? Is it for debugging purposes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, those were not supposed to be there. Fixed in ab44de3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the fix 👍
This PR updates the ExPlat implementation so it can support the new
experiment_names
parameter which was added to the "fetch assignments" endpoint, as defined in https://github.com/Automattic/experimentation-platform/issues/606.This depends on #1969.
In practice, this mainly impacts the usage of
ExperimentStore::fetchAssignments
, which now requires a list ofString
with the experiment names as its second parameter:To test
Make sure all unit tests pass and/or use the following steps on the example app:
Repeat providing single/multiple experiment names and also no experiment name at all (which should return 0 assignments).