Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Site directly instead of Site Store in test #1489

Merged
merged 1 commit into from
Jan 29, 2020
Merged

Use Site directly instead of Site Store in test #1489

merged 1 commit into from
Jan 29, 2020

Conversation

mchowning
Copy link
Contributor

Summary

Uses the site directly instead of getting the site id from the Site Store.

This is a fix for a broken test merged in #1459 . The tests passed when run individually, but failed when the entire class was run.

To Test

Verfiy that the ReleaseStack_ReactNativeWPComRequestTest tests pass, i.e.:

./gradlew cAT -Pandroid.testInstrumentationRunnerArguments.class=org.wordpress.android.fluxc.release.ReleaseStack_ReactNativeWPComRequestTest

@oguzkocer oguzkocer self-assigned this Jan 29, 2020
oguzkocer
oguzkocer approved these changes Jan 29, 2020
View reviewed changes
Copy link
Contributor

@oguzkocer oguzkocer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@oguzkocer oguzkocer merged commit a38f48b into develop Jan 29, 2020
@oguzkocer oguzkocer deleted the fix_wpcomrequest_test branch January 29, 2020 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oguzkocer oguzkocer oguzkocer approved these changes

@aforcier aforcier Awaiting requested review from aforcier

@marecar3 marecar3 Awaiting requested review from marecar3

Assignees

@oguzkocer oguzkocer

Labels
Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mchowning @oguzkocer