Add defences for bad APIs #1485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbradbury
reviewed
Jan 23, 2020
| @@ -75,10 +75,10 @@ constructor( | |||
| @SerializedName("id") val gatewayId: String, | |||
| @SerializedName("title") val title: String?, | |||
| @SerializedName("description") val description: String?, | |||
| @SerializedName("order") val order: Int, | |||
| @SerializedName("enabled") val enabled: Boolean, | |||
| @SerializedName("order") val order: String?, | |||
There was a problem hiding this comment.
@0nko I feel like I need some background here. Why are we treating "order" as a string when the API docs say it's an integer?
There was a problem hiding this comment.
@nbradbury I should have linked this, sorry - woocommerce/woocommerce-android#1840
There was a problem hiding this comment.
@0nko What will happen now if the response contains "order" as an int?
There was a problem hiding this comment.
It'll work automatically, Gson will treat it as a string. I tested it to make sure but I haven't created a separate client PR because there's another FluxC PR I want to include in the hotfix. You can just reference this commit to test it yourself.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes all gateway response parameters nullable and even handles possible empty strings in place of integers.