Upgrade Gradle to 5.4.1, gradle plugin to 3.5.1 and WellSql to 1.5.0 #1397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks Oguz! I've
=> everything seems to be working as expected. SideNote: I'll approve this PR and merge it as soon as we freeze WPAndroid 13.4. |
2 tasks
|
@malinajirka Let's keep this PR as a draft until wordpress-mobile/WordPress-Android#10583 is ready to be merged in just in case the different Gradle versions create issues. There are currently some test and lint issues we need to address. |
malinajirka
approved these changes
Oct 11, 2019
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the Gradle version to
5.4.1, gradle plugin version to3.5.1and WellSql to1.5.0. The upgrade was mostly straightforward withWellSqlbeing the only blocker: wordpress-mobile/wellsql#14. After the upgrade I started to get a lint error for not usingLocaleintoLowerCasecalls, so I have added that in 7482c7f. Android Studio suggested to useLocale.ROOTif the string was internal only, so I opted to go with that.Note that I am opening this PR as a draft until the code freeze
13.4for WPAndroid happens today just in case it's a troublesome upgrade. Feel free to mark the PR as ready to review once that happens.