Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix migration issue #1344

Merged
merged 1 commit into from
Aug 12, 2019
Merged

Fix migration issue #1344

merged 1 commit into from
Aug 12, 2019

Conversation

malinajirka
Copy link
Contributor

@malinajirka malinajirka commented Aug 12, 2019

Fixes migration of CHANGES_CONFIRMED_CONTENT_HASHCODE field as it had a wrong type in the migration script.

cc @loremattei This PR should fix the issue with migration in WPAndroid 13.1. However, I've fixed the migration script so the fix won't work for users who have already updated the app. But AFAIU WPAndroid 13.1 hasn't been released to anyone yet (not even to beta users), right?

Testing steps in WPAndroid

  1. Install release/13.0
  2. Log in and open post list
  3. Checkout release/13.1 and update FluxC hash to 5aa79629b12dabd24784548b8cf183bca458846b
  4. Update the app
  5. Open Post List and scroll down -> notice the app doesn't crash

Copy link
Member

@shiki shiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and no crash experienced. 🎉

@shiki shiki merged commit 084b303 into develop Aug 12, 2019
@shiki shiki deleted the fix-migration branch August 12, 2019 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants