Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wc/1291 revert notifs constraint #1292

Merged
merged 3 commits into from
Jun 21, 2019
Merged

Conversation

AmandaRiu
Copy link
Contributor

Fixes #1291 by removing the foreign key constraint code originally added in #1285 and adding a db migration to ensure the constraint is removed successfully for devices already running the old code.

Recommended Test Scenarios

  • Run all the tests in NotificationSqlutilsTest and verify they pass.
  • Run all the tests in ReleaseStack_NotificationTest and verify they pass.
  • Run the example app using the develop branch and then install this version and verify the upgrade is functioning properly.
  • Uninstall and reinstall this version of the example app and make sure notification tests in the Notifications screen are all working.

Copy link
Contributor

@anitaa1990 anitaa1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@anitaa1990 anitaa1990 merged commit 5f057c5 into develop Jun 21, 2019
@anitaa1990 anitaa1990 deleted the wc/1291_revert_notifs_constraint branch June 21, 2019 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revert foreign key constraints between SiteModel and NotificationModel
2 participants