AutoUpload only publishable local drafts

[malinajirka]

Fixes #9955

LocalDraftUploadStarted doesn't automatically upload local drafts which are not publishable.

To test:

1. Turn on Airplane mode
2. My Site -> Blog Posts
3. Create a Post
4. Enter a title
5. Press back
6. Open the post
7. Remove the title
8. Press back
9. Turn off airplane mode + you can also pull to refresh
10. Notice the failed upload notification isn't shown
11. Turn on airplane mode
12. Create a local draft
13. Turn off airplane mode
14. Make sure the second local draft gets uploaded - in other words make sure the "unpublishable" draft doesn't block all uploads

Update release notes:

• The feature hasn't been released yet + the changes are too minor

Before/After gifs

[shiki]

@malinajirka, the code looks good to me. I just wanted to confirm if you're seeing this bug. The changes cause duplicate Post uploads for me. I followed the testing steps that you mentioned.

This is on an emulator, Nexus 5X, Android 9.

I can't quite figure out why. If I remove the new filter { } that you added, the upload seems to be okay. I think this means we'll have to add concurrency protection in LocalDraftUploadStarter. 🤔

Feel free to merge if it is not related. We can create a new issue for it.

[maxme]

@shiki I wasn't able to repro the bug, maybe I missed a step:

I wonder if it comes from somewhere else (and we should open a ticket for it), maybe we enqueue the same upload twice (I don't remember where we check for an existing upload)? could be a race condition?

[shiki]

@maxme I was able to condense the steps and can somewhat consistently reproduce it even without the new filter. I added the steps in this comment on an existing issue #8594.

I'll merge this since this is not the cause.