Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not start Jetpack flow when leaving Connect activity #9868

Merged
merged 1 commit into from
May 15, 2019
Merged

Do not start Jetpack flow when leaving Connect activity #9868

merged 1 commit into from
May 15, 2019

Conversation

planarvoid
Copy link
Contributor

@planarvoid planarvoid commented May 15, 2019 •
edited
Loading

Fixes #8434

The WPMainActivity triggers account update in onResume. At that time the StatsConnectJetpackActivity is not yet finished so it receives the OnAccountChanged event and starts the Jetpack connection flow in the WebView. This PR introduces a check that checks whether the app is not finishing when we receive the event.

To test:

  • Create a fresh self-hosted site without Jetpack
  • Go to Stats
  • Click "Back" on the screen that tells you to install Jetpack
  • You go back to the Main activity

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@planarvoid planarvoid added this to the 12.5 milestone May 15, 2019
@planarvoid planarvoid requested a review from khaykov May 15, 2019 10:05
@planarvoid planarvoid self-assigned this May 15, 2019
@planarvoid planarvoid mentioned this pull request May 15, 2019
Closed
8 tasks
@khaykov khaykov self-assigned this May 15, 2019
khaykov
khaykov approved these changes May 15, 2019
View reviewed changes
Copy link
Member

@khaykov khaykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :shipit:
I was able to reproduce the originall issue (only happened to me when I was also logged in to WordPress.com account) and can confirm that the fix works.

@khaykov khaykov merged commit 0e1a701 into develop May 15, 2019
@oguzkocer oguzkocer deleted the fix/do_not_start_jetpack_flow_when_leaving_connection_activity branch April 15, 2020 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khaykov khaykov khaykov approved these changes

Assignees

@khaykov khaykov

@planarvoid planarvoid

Labels
Jetpack [Type] Bug
Projects
None yet
Milestone
12.5
Development

Successfully merging this pull request may close these issues.

Wrong behaviour in self-hosted Jetpack install
2 participants
@planarvoid @khaykov