Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add connection pool that doesn't keep failed sockets #9862

Merged
merged 1 commit into from
May 21, 2019

Conversation

planarvoid
Copy link
Contributor

Fixes #9843
There seems to be a known issue in OkHttp with Http2. Whenever there is a SockedTimeoutException, the socked that failed is kept in the pool and this causes the same exception to happen again even though the connection is restored. This solution should fix the issue by setting the connection pool to not hold failed sockets.
It's based on this answer: square/okhttp#3146 (comment)

To test:

  • Upload a cropped gravatar
  • Everything works as expected

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

@planarvoid planarvoid added this to the 12.5 milestone May 14, 2019
@planarvoid planarvoid requested a review from malinajirka May 14, 2019 15:27
@planarvoid planarvoid self-assigned this May 14, 2019
@loremattei loremattei modified the milestones: 12.5 ❄️, 12.6 May 20, 2019
@loremattei
Copy link
Contributor

Hey! I'm moving this to 12.6 since 12.5 has been cut. If you want this to land 12.5, please feel free to target the release branch and ping me to build a new beta.

@malinajirka
Copy link
Contributor

Thanks for looking into this @planarvoid !

I've tested both successful upload and re-upload after timed out upload and everything works as expected. Thanks!

@malinajirka malinajirka merged commit 33cbe73 into develop May 21, 2019
@malinajirka malinajirka deleted the fix_socket_timeout_exception_in_gravatar_api branch May 21, 2019 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not a Crash: SocketTimeoutException: timeout while loading Gravatar
3 participants