Add connection pool that doesn't keep failed sockets #9862
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9843
There seems to be a known issue in OkHttp with Http2. Whenever there is a SockedTimeoutException, the socked that failed is kept in the pool and this causes the same exception to happen again even though the connection is restored. This solution should fix the issue by setting the connection pool to not hold failed sockets.
It's based on this answer: square/okhttp#3146 (comment)
To test:
Update release notes:
RELEASE-NOTES.txt
.