Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash with missing view in StatsViewAllFragment #9842

Merged
merged 1 commit into from
May 14, 2019

Conversation

planarvoid
Copy link
Contributor

Fixes #9750
This was already fixed in the StatsFragment. When we do the postDelayed to hide/show the toolbar shadow, it's possible that the view is already gone (when the activity is killed). We need to check whether we're still showing the layout before setting the shadow.

To test:

  • Go to a site with lot of stats
  • Go to Insights/Comments card
  • Click on "View more"
  • The top toolbar ("Comments") doesn't have a shadow
  • The tabs toolbar ("Authors" and "Posts and Pages") does have a shadow
  • Go to Insights/Tags and Categories
  • Click on "View more"
  • The top toolbar (Tags & Categories) does have a shadow

Update release notes:

  • If there are user facing changes, I have added an item to RELEASE-NOTES.txt.

Copy link
Member

@khaykov khaykov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@khaykov khaykov merged commit 1a4f71f into develop May 14, 2019
@oguzkocer oguzkocer deleted the crash/9750-fix_crash_in_all_time_view branch April 15, 2020 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash: NPE in StatsViewAllFragment$setupObservers
3 participants