Fix crash in all time stats #9552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpmobilebot
reviewed
Apr 9, 2019
| fun `best day is null when it's empty`() = test { | ||
| val forced = false | ||
| val refresh = true | ||
| val model = InsightsAllTimeModel(1L, null, 1, 0, 0, "", 0) |
There was a problem hiding this comment.
Reporter: Checkstyle
Rule: no-multi-spaces
Severity: ERROR
File: /home/circleci/project/WordPress/src/test/java/org/wordpress/android/ui/stats/refresh/lists/sections/insights/usecases/AllTimeStatsUseCaseTest.kt L134
Unnecessary space(s)
0nko
approved these changes
Apr 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8886
Sometimes the
viewsBestDayseems to be empty. The date parses cannot handle this use case. I'm changing the code so we only parse a non-empty date. If it's empty, we don't show the tooltip.I've added a test to cover this scenario
To test: